Bug 516420: Problem hover status color should be the same as for normal
content

Adding missing set*Color() calls to fix reported bug.

Cause: 
AbstractAnnotationHover extends AbstractInformationControl and does
some setColoring for it's private child composite without updating the
color of the parent structure.

Test:
- Change information hover colors in preference
- Hover over snippet described in bug description

Before: Strip at the bottom was of different color.
After: Strip at the bottom is the same color as inner content.
   (see attached screenshot in bug).

Reviewer note:
- I investigated private setColorAndFont(..). It is only used 
  for coloring of child elements, and only in deferredCreateContent().
  As such, there is no situation where setColorAndFont(..) would be
  called without set*Color() being called first.
  This ensures consistent colors for this class.

Note, after doing a root-cause analysis, I found the same sort-of
issue in a few other classes that extend AbstractInformationControl,
namely:
- BrowserInformationControl
- ExpressionInformationControl
- LinkListInformationControl
I will address those in separate bug because they
1) need the new INFORMATION_ api (instead of further using HOVER_)
2) some are in separate repositories. (jdt/platform)



Change-Id: I837eceaf00b8ab8162f8490a1b48425bfc38210d
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=516420
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
1 file changed
tree: 69f2ba081eb4613a169750f91014f67f3ace2eff
  1. org.eclipse.jdt.astview/
  2. org.eclipse.jdt.astview.feature/
  3. org.eclipse.jdt.core.manipulation/
  4. org.eclipse.jdt.jeview/
  5. org.eclipse.jdt.jeview.feature/
  6. org.eclipse.jdt.junit/
  7. org.eclipse.jdt.junit.core/
  8. org.eclipse.jdt.junit.runtime/
  9. org.eclipse.jdt.junit4.runtime/
  10. org.eclipse.jdt.text.tests/
  11. org.eclipse.jdt.ui/
  12. org.eclipse.jdt.ui.examples.javafamily/
  13. org.eclipse.jdt.ui.examples.projects/
  14. org.eclipse.jdt.ui.tests/
  15. org.eclipse.jdt.ui.tests.refactoring/
  16. org.eclipse.ltk.core.refactoring/
  17. org.eclipse.ltk.core.refactoring.tests/
  18. org.eclipse.ltk.ui.refactoring/
  19. org.eclipse.ltk.ui.refactoring.tests/
  20. tests-pom/
  21. .gitignore
  22. pom.xml
  23. README.md
README.md

Contributing to JDT UI - Java development tools UI

Thanks for your interest in this project.

Project description:

The JDT UI implements the user interface for the Java IDE. This includes views like Package Explorer and JUnit, the Java and properties files editors, Java search, and refactorings. Website: http://www.eclipse.org/jdt/ui/

How to contribute:

Contributions to JDT UI are most welcome. There are many ways to contribute, from entering high quality bug reports, to contributing code or documentation changes. For a complete guide, see the [How to Contribute] 1 page on the team wiki.

Developer resources:

Information regarding source code management, builds, coding standards, and more.

Contributor License Agreement:

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).

Forum:

Public forum for Eclipse JDT users.

Search for bugs:

This project uses Bugzilla to track ongoing development and issues.

Create a new bug:

Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!

Contact:

Contact the project developers via the project's “dev” list.

License

Eclipse Public License (EPL) v1.0