Google Git
Sign in
eclipse / jdt / eclipse.jdt.ui / refs/tags/I20201027-2350
commit591c489465555590455cc09935fb25aa1d94c3d8[log] [tgz]
authorCarsten Hammer <carsten.hammer@t-online.de>Sat Oct 24 14:56:19 2020 +0200
committerJeff Johnston <jjohnstn@redhat.com>Tue Oct 27 14:50:43 2020 -0400
tree1c2001d18d966362d3685fe50958d6978203e7f1
parent10d4ec67649ed96e0f214228fb9b3525a8c8fab4 [diff]
Bug 568197 - Using .equals to compare two

org.eclipse.jdt.core.IJavaElement[]'s, (equivalent to ==) in
org.eclipse.jdt.internal.ui.typehierarchy.TypeHierarchyViewPart.updateInput(IJavaElement[])

and

org.eclipse.jdt.internal.ui.typehierarchy.TypeHierarchyViewPart.setInputElements(IJavaElement[])

This method invokes the .equals(Object o) method on an array. Since
arrays do not override the equals method of Object, calling equals on an
array is the same as comparing their addresses. To compare the contents
of the arrays, use java.util.Arrays.equals(Object[], Object[]). To
compare the addresses of the arrays, it would be less confusing to
explicitly check pointer equality using ==.

Rank: Scariest (3), confidence: Normal
Pattern: EC_BAD_ARRAY_COMPARE
Type: EC, Category: CORRECTNESS (Correctness)


Change-Id: I3075ce4e36a525d51f46d8652246525f6523b7a6
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
1 file changed
tree: 1c2001d18d966362d3685fe50958d6978203e7f1
  1. org.eclipse.jdt.astview/
  2. org.eclipse.jdt.astview.feature/
  3. org.eclipse.jdt.core.manipulation/
  4. org.eclipse.jdt.jeview/
  5. org.eclipse.jdt.jeview.feature/
  6. org.eclipse.jdt.junit/
  7. org.eclipse.jdt.junit.core/
  8. org.eclipse.jdt.junit.runtime/
  9. org.eclipse.jdt.junit4.runtime/
  10. org.eclipse.jdt.junit5.runtime/
  11. org.eclipse.jdt.text.tests/
  12. org.eclipse.jdt.ui/
  13. org.eclipse.jdt.ui.examples.javafamily/
  14. org.eclipse.jdt.ui.examples.projects/
  15. org.eclipse.jdt.ui.tests/
  16. org.eclipse.jdt.ui.tests.refactoring/
  17. org.eclipse.ltk.core.refactoring/
  18. org.eclipse.ltk.core.refactoring.tests/
  19. org.eclipse.ltk.ui.refactoring/
  20. org.eclipse.ltk.ui.refactoring.tests/
  21. tests-pom/
  22. .gitignore
  23. CONTRIBUTING
  24. LICENSE
  25. NOTICE
  26. pom.xml
  27. README.md
README.md

Contributing to JDT UI - Java development tools UI

Thanks for your interest in this project.

Project description:

The JDT UI implements the user interface for the Java IDE. This includes views like Package Explorer and JUnit, the Java and properties files editors, Java search, and refactorings. Website: http://www.eclipse.org/jdt/ui/

How to contribute:

Contributions to JDT UI are most welcome. There are many ways to contribute, from entering high quality bug reports, to contributing code or documentation changes. For a complete guide, see the [How to Contribute] 1 page on the team wiki.

Developer resources:

Information regarding source code management, builds, coding standards, and more.

Contributor License Agreement:

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).

Forum:

Public forum for Eclipse JDT users.

Search for bugs:

This project uses Bugzilla to track ongoing development and issues.

Create a new bug:

Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!

Contact:

Contact the project developers via the project's “dev” list.

License

Eclipse Public License (EPL) v2.0