v6.5.1
[574133] Wrong Note text alignment in collaborative environment

When a Note is created in a Sirius diagram in a collaborative context
(Obeo Designer Team Edition or Team for Capella), the text is centered
vertically (instead of being aligned at the top).
Indeed, the implementation of ESTRING_TO_STRING_MAP_ENTRY is not
obligatorily a org.eclipse.emf.ecore.impl.EStringToStringMapEntryImpl.
So this commit adapts the code of
org.eclipse.sirius.diagram.ui.internal.view.factories.SiriusNoteViewFactory.createDefaultVerticalAlignmentEAnnotation()
to handle this case.
This commit also adds a migration participant to fix the notes created
before this version.

Tests:
* org.eclipse.sirius.tests.unit.diagram.migration.NoteShapeDefaultLabelAlignmentMigrationTest
always checks the migration of initial problem (bugzilla 515044).
* org.eclipse.sirius.tests.unit.diagram.migration.NoteShapeDefaultLabelAlignmentMigrationTest2
checks the migration of the new problem corresponding to this bugzilla.
* org.eclipse.sirius.tests.swtbot.NoteCreationTest has been updated to
also check that the GMF styles concerning note text alignment.

Bug: 574133
Change-Id: I2acff0a2f69d9623e1576d46759b521b01c0bec9
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
11 files changed
tree: 688968186d78592a23fdcd484ef11c6dd1618619
  1. packaging/
  2. plugins/
  3. releng/
  4. .gitattributes
  5. .gitignore
  6. build.sh
  7. CONTRIBUTING
  8. Jenkinsfile
  9. LICENSE
  10. NOTICE
  11. pom.xml
  12. README.md
README.md

Eclipse Sirius

Build Status

Sirius enables the specification of a modeling workbench in terms of graphical, table or tree editors with validation rules and actions using declarative descriptions.

For more details see the project page and the main wiki page.

Building

The build uses Tycho. To launch a complete build, issue

mvn clean package

from the top-level directory. The resulting update-site (p2 repository) can be found in packaging/org.eclipse.sirius.update/target/repository.

By default the build uses a Neon-based target platform. You can specify a different platform like this:

mvn clean package -Dplatform-version-name=name

where name can be any of the following values:

  • mars (Eclipse 4.5)
  • neon (Eclipse 4.6, the default and reference target platform)
  • canary (uses nightly builds of all our dependencies, only used for testing)

The corresponding target platform definitions can be found in releng/org.eclipse.sirius.targets.