Address Sonar issues in UI for Office files
This commit addresses a number of bugs and
code smells reported by Sonar in Eclipse Capra's
user interface for Office files.
Change-Id: Ic2d0fbf2df9a23205aa29766e1e7b076edf3cd3d
diff --git a/bundles/org.eclipse.capra.ui.office/src/org/eclipse/capra/ui/office/model/CapraOfficeObject.java b/bundles/org.eclipse.capra.ui.office/src/org/eclipse/capra/ui/office/model/CapraOfficeObject.java
index 71be1ec..3d4f169 100644
--- a/bundles/org.eclipse.capra.ui.office/src/org/eclipse/capra/ui/office/model/CapraOfficeObject.java
+++ b/bundles/org.eclipse.capra.ui.office/src/org/eclipse/capra/ui/office/model/CapraOfficeObject.java
@@ -20,8 +20,6 @@
import java.nio.file.NoSuchFileException;
import org.eclipse.capra.ui.office.exceptions.CapraOfficeObjectNotFound;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
* This class provides a custom object for describing the contents of MS Excel
@@ -32,8 +30,6 @@
*/
public class CapraOfficeObject {
- private static final Logger LOG = LoggerFactory.getLogger(CapraOfficeObject.class);
-
/**
* The MS Office file-types that are supported by the plugin.
*/
diff --git a/bundles/org.eclipse.capra.ui.office/src/org/eclipse/capra/ui/office/views/OfficeView.java b/bundles/org.eclipse.capra.ui.office/src/org/eclipse/capra/ui/office/views/OfficeView.java
index 939103b..a5f6ee5 100644
--- a/bundles/org.eclipse.capra.ui.office/src/org/eclipse/capra/ui/office/views/OfficeView.java
+++ b/bundles/org.eclipse.capra.ui.office/src/org/eclipse/capra/ui/office/views/OfficeView.java
@@ -48,7 +48,6 @@
import org.eclipse.jface.action.MenuManager;
import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.viewers.DoubleClickEvent;
-import org.eclipse.jface.viewers.IDoubleClickListener;
import org.eclipse.jface.viewers.IStructuredContentProvider;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.jface.viewers.ITableLabelProvider;
@@ -281,13 +280,7 @@
viewer.addDropSupport(ops, transfersIn, new SelectionDropAdapter(viewer));
viewer.addDragSupport(ops, transfersOut, new SelectionDragAdapter(viewer));
- viewer.addDoubleClickListener(new IDoubleClickListener() {
-
- @Override
- public void doubleClick(DoubleClickEvent event) {
- showObjectDetails(event, parent.getShell());
- }
- });
+ viewer.addDoubleClickListener(event -> showObjectDetails(event, parent.getShell()));
}
/**
