Bug 488008 - StyledTextArea annotation support Change-Id: I2bbf2ff2baf1def861e72c6f6f62af5ccccf83f5
diff --git a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/NodeCachePane.java b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/NodeCachePane.java index b147bd8..d9698bc 100644 --- a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/NodeCachePane.java +++ b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/NodeCachePane.java
@@ -22,8 +22,8 @@ } node.setVisible(true); }); - cache.addOnRelease(node->node.setVisible(false)); - cache.addOnClear(node->getChildren().remove(node)); + cache.addOnRelease( node -> getChildren().remove(node)); // FIXME modified by Tom leads to more and more text instances in AnnotationOverlay + cache.addOnClear( node -> getChildren().remove(node)); } protected Node getNode() {
diff --git a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/ReuseCache.java b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/ReuseCache.java index c47957e..e32e5ba 100644 --- a/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/ReuseCache.java +++ b/bundles/runtime/org.eclipse.fx.ui.controls/src/org/eclipse/fx/ui/controls/styledtext/ReuseCache.java
@@ -51,7 +51,7 @@ public void releaseElement(T element) { active.remove(element); onRelease.forEach(a->a.accept(element)); - free.push(element); +// free.push(element); //FIXME Tom no caching as of NOW } public void clearFreeElements() {