)]}'
{
  "commit": "8dbc29aa4279e9c3de75001bbeb1ee820ea54320",
  "tree": "824dc53182f73b01724c87feb134a1d051cfab99",
  "parents": [
    "ccbcbf6716145709aeeb3f48eace401f78542b27"
  ],
  "author": {
    "name": "Fabio Zadrozny",
    "email": "fabiofz@gmail.com",
    "time": "Wed Feb 21 13:46:41 2018 -0300"
  },
  "committer": {
    "name": "Fabio Zadrozny",
    "email": "fabiofz@gmail.com",
    "time": "Wed Feb 21 17:19:01 2018 -0300"
  },
  "message": "Bug 8519 [Macros] - Code review feedback\n\n- use XML instead of JavaScript for persisting macro\n- fix up javadocs\n- use Assert, no RuntimeExceptions\n- MacroServiceImplementation -\u003e MacroServiceImpl\n- allow clients to change current macro on stop record notification\n\nChange-Id: I8f6f7689ef3cf302c7a6378a66ab779045c9c1ac\nSigned-off-by: Fabio Zadrozny \u003cfabiofz@gmail.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5306d02afc575aaad2c89207c8b3a0405574169d",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/META-INF/MANIFEST.MF",
      "new_id": "ba41e2758e400148d335d863209bc076ab30cc6c",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/META-INF/MANIFEST.MF"
    },
    {
      "type": "modify",
      "old_id": "0ae650571f2d394d907eb3f33ef2316f1f22f4c5",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/OSGI-INF/l10n/bundle.properties",
      "new_id": "583a12519db82d08be99eb0d94569adee1b500be",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/OSGI-INF/l10n/bundle.properties"
    },
    {
      "type": "modify",
      "old_id": "b2a339ac9ad85e5c1bb1393831f1f582c50541d7",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/schema/commandHandling.exsd",
      "new_id": "fbaddb65f0e39f77bbd1b2683975ca51666b88f0",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/schema/commandHandling.exsd"
    },
    {
      "type": "modify",
      "old_id": "bef089e96e320d7389c2a03d31c503519f54308c",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/schema/macroInstructionsFactory.exsd",
      "new_id": "6b7bec96bfc2aa8433f19e616ff133db99634ce0",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/schema/macroInstructionsFactory.exsd"
    },
    {
      "type": "modify",
      "old_id": "88c91cf7632c74f9747fedec986e24434f900ae6",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/schema/macroStateListeners.exsd",
      "new_id": "ee5f66e7dddaee82a06bd231b193f649bbadad3d",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/schema/macroStateListeners.exsd"
    },
    {
      "type": "modify",
      "old_id": "ca98f0f72f2b6733515529227a498b447697408c",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/Activator.java",
      "new_id": "1d1482ad9147e937c2f246bc34a16f9f07d59c6f",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/Activator.java"
    },
    {
      "type": "modify",
      "old_id": "615b2f9b23ae4a424e2be04b3a9347e117bdea99",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/EMacroService.java",
      "new_id": "62e493b7656f05e0696ced3275606ef5b90e2948",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/EMacroService.java"
    },
    {
      "type": "modify",
      "old_id": "e3648aa7b93b1c6c7c1ba7578acc8da947c8a8e9",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/IMacroInstruction.java",
      "new_id": "6c9707aa79cb8f8faadabdd700634c79c1dd49fa",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/IMacroInstruction.java"
    },
    {
      "type": "modify",
      "old_id": "c542eba2348ae6779f81d3d5f6bff03402e9075b",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/IMacroPlaybackContext.java",
      "new_id": "21e850d33f9b62b0365bb02e624358c149234132",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/IMacroPlaybackContext.java"
    },
    {
      "type": "modify",
      "old_id": "0c1c13da3cea1e873952b9832236de429ffa49ce",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/ComposableMacro.java",
      "new_id": "6ffb8fb58aff4fad60b004739ee254c6e54f0c8d",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/ComposableMacro.java"
    },
    {
      "type": "modify",
      "old_id": "c76b1209afb0d8cb9d2b3f88979abfbcd466f485",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/IMacro.java",
      "new_id": "22059adcac61e3dff8f75e95099c354fdf00e039",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/IMacro.java"
    },
    {
      "type": "delete",
      "old_id": "cbe44ed8afec2088df5dc2d97f58aadeb7620722",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/JSONHelper.java",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "d6f962fe9fa77d1cd81875da0f7baa257fc44c42",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/MacroManager.java",
      "new_id": "afc178a5c023d916b5ba88be2c13b4abecd51ae4",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/MacroManager.java"
    },
    {
      "type": "modify",
      "old_id": "885eda277b136ddf2d044c0df6bef0e43b80ff20",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/MacroPlaybackContextImpl.java",
      "new_id": "92603d40200872bed0bf0f13aa569934b041272b",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/MacroPlaybackContextImpl.java"
    },
    {
      "type": "modify",
      "old_id": "da1fd60469f45db50b2d1db199fd03a4e459e8fa",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/MacroServiceCreationFunction.java",
      "new_id": "8d2fdfaa327bd8aee776189a392a6c1a0ab90c3a",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/MacroServiceCreationFunction.java"
    },
    {
      "type": "rename",
      "old_id": "1df05f76b3c5799a097cf14147a42c753f031d1c",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/MacroServiceImplementation.java",
      "new_id": "d7a7f74d8107f745ea4b6f425d6771184e606375",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/MacroServiceImpl.java",
      "score": 95
    },
    {
      "type": "modify",
      "old_id": "6fb60b6c8eb6f4bbf639cd9f0755cd1a8fce9b54",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/Messages.java",
      "new_id": "5734d1d4d936700cd4c60f12e0b86937c4fbcf56",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/Messages.java"
    },
    {
      "type": "delete",
      "old_id": "24af1086574c9861626add0aaadd7a38e146c037",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/SavedJSMacro.java",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "16d91e0d20a4f335a1667f3faebb0be6030bba39",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/SavedXMLMacro.java"
    },
    {
      "type": "modify",
      "old_id": "dd8d464024a394cf79999caf6cfc95b1013c2dbb",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/messages.properties",
      "new_id": "3677ab5bbe77955593a95b4e324dee1b34ba030b",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/internal/messages.properties"
    },
    {
      "type": "modify",
      "old_id": "52a1127a58a46e9cca004038b77ad88d3a7e48f1",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/package-info.java",
      "new_id": "ce4b4691d76c2de661f77502bf1779a3e2dd389e",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.core.macros/src/org/eclipse/e4/core/macros/package-info.java"
    },
    {
      "type": "modify",
      "old_id": "85d62cc0daaf541deba1a3b78d5f9f319d624149",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/Activator.java",
      "new_id": "ca13b48b2c5f2266db048328e958f13641cd0e1d",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/Activator.java"
    },
    {
      "type": "modify",
      "old_id": "fa3664d8344e5d786c2e2f05193d436671941357",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/internal/EditorUtils.java",
      "new_id": "373352b06deecffa28ef48a2fab92064c235310f",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/internal/EditorUtils.java"
    },
    {
      "type": "modify",
      "old_id": "a60170bce74379e388c9b840b679853caa553646",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/internal/UserNotifications.java",
      "new_id": "82ca130d77138701e8e6077f8837b1e0f0701250",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/internal/UserNotifications.java"
    },
    {
      "type": "modify",
      "old_id": "78fd11327ae55978648bfe5858d66a0c96fbf809",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/internal/actions/MacroPlaybackAction.java",
      "new_id": "ee1014ea471ca4a1fa7c7dbbadc4696ff12128c1",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/internal/actions/MacroPlaybackAction.java"
    },
    {
      "type": "modify",
      "old_id": "8920079222e408820c9409fb2fc4a419c0a51e8d",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/internal/keybindings/CommandManagerExecutionListener.java",
      "new_id": "72b2c42bac1fffa606bb6ba2fe6f5ee0cd10225d",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.e4.ui.macros/src/org/eclipse/e4/ui/macros/internal/keybindings/CommandManagerExecutionListener.java"
    },
    {
      "type": "modify",
      "old_id": "f2ebe0fa43b1553b6e741283949841a8b4a3a176",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/plugin.xml",
      "new_id": "7408dd64cdcdd5193ef65d8d159db5b8e60b2316",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/plugin.xml"
    },
    {
      "type": "modify",
      "old_id": "b37e3cfd8cd94385aa957df582169fe888720a37",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/AbstractSWTEventMacroInstruction.java",
      "new_id": "9310ea55c066a9ec85361e55726e81393a4e7797",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/AbstractSWTEventMacroInstruction.java"
    },
    {
      "type": "delete",
      "old_id": "17ddb4fdbc1b7971a3a0ab19c8e4ffdb2b7d1405",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/EditorPartMacroInstaller.java",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "1b0070b8a0435fe97ff1e7956dfbc7c5a89ccb9e",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/MacroStyledTextInstaller.java",
      "new_id": "740b7f74c658a46819f6c343d38d8925ee0c8b4f",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/MacroStyledTextInstaller.java"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "6231ecadcb06ba8f3777a3ee45639d7f1627ae9d",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/MacroStyledTextModeHandler.java"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "e9dbe11a85e51c29c0f8e407c226f5fef2856d99",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/NotifyMacroOnlyInCurrentEditorInstaller.java"
    },
    {
      "type": "rename",
      "old_id": "5c2ef1ab2913f2e9586b3b3f4def4a89d28ba336",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/NotifyMacroOnlyInCurrentEditor.java",
      "new_id": "c9586dab598bcf0343c8164d98b235adb08e23ba",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/NotifyMacroOnlyInCurrentEditorListener.java",
      "score": 76
    },
    {
      "type": "modify",
      "old_id": "1f666ad441ee91c39a01dd04e8d807ed29e5ba94",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/StyledTextKeyDownMacroInstruction.java",
      "new_id": "970986c27ae92bb3f3ea24d579fb3c5291c3482b",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.ui.workbench.texteditor.macros/src/org/eclipse/ui/workbench/texteditor/macros/internal/StyledTextKeyDownMacroInstruction.java"
    },
    {
      "type": "delete",
      "old_id": "c3da94dfe38db59680f9cd95e924abdb0504e3ca",
      "old_mode": 33188,
      "old_path": "tests/org.eclipse.e4.ui.macros.tests/src/org/eclipse/e4/ui/macros/tests/JSONHelperTest.java",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "ff490da234a17107c65936a9394be1a040f39206",
      "old_mode": 33188,
      "old_path": "tests/org.eclipse.e4.ui.macros.tests/src/org/eclipse/e4/ui/macros/tests/KeyBindingDispatcherMacroIntegrationTest.java",
      "new_id": "66064a88b493da913567deb4a67f8be5a9426c68",
      "new_mode": 33188,
      "new_path": "tests/org.eclipse.e4.ui.macros.tests/src/org/eclipse/e4/ui/macros/tests/KeyBindingDispatcherMacroIntegrationTest.java"
    },
    {
      "type": "modify",
      "old_id": "ae9d7c318249fb05e4664291dba2fa3ffbf2a6b1",
      "old_mode": 33188,
      "old_path": "tests/org.eclipse.e4.ui.macros.tests/src/org/eclipse/e4/ui/macros/tests/MacroTest.java",
      "new_id": "61f1cae1b827b410a9e11842efe6c204482c8599",
      "new_mode": 33188,
      "new_path": "tests/org.eclipse.e4.ui.macros.tests/src/org/eclipse/e4/ui/macros/tests/MacroTest.java"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "4b4c6fed21c19b70569987661f4d6babb65ba60d",
      "new_mode": 33188,
      "new_path": "tests/org.eclipse.e4.ui.macros.tests/src/org/eclipse/e4/ui/macros/tests/SavedXMLMacroTest.java"
    }
  ]
}