TCI - Make GenericEditor more accessible
- change handleRemove, getDiagnostic and notifyValidationListeners from
private to protected
- add javadoc
Change-Id: I602836d654f0377cc089340e48ecc72b5e90c639
Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
diff --git a/bundles/org.eclipse.emfforms.swt.treemasterdetail/src/org/eclipse/emfforms/spi/swt/treemasterdetail/diagnostic/DiagnosticCache.java b/bundles/org.eclipse.emfforms.swt.treemasterdetail/src/org/eclipse/emfforms/spi/swt/treemasterdetail/diagnostic/DiagnosticCache.java
index 0150ed0..7252960 100644
--- a/bundles/org.eclipse.emfforms.swt.treemasterdetail/src/org/eclipse/emfforms/spi/swt/treemasterdetail/diagnostic/DiagnosticCache.java
+++ b/bundles/org.eclipse.emfforms.swt.treemasterdetail/src/org/eclipse/emfforms/spi/swt/treemasterdetail/diagnostic/DiagnosticCache.java
@@ -271,19 +271,33 @@
}
- private void handleRemove(EObject oldValue, DiagnosticCache cache) {
+ /**
+ * Remove the given object from the cache.
+ *
+ * @param object the EObject to remove
+ * @param cache the DiagnosticCache from which the object should be removed
+ * @since 1.25
+ */
+ protected void handleRemove(EObject object, DiagnosticCache cache) {
final Set<EObject> toRemove = new LinkedHashSet<EObject>();
- toRemove.add(oldValue);
- final TreeIterator<EObject> iterator = EcoreUtil.getAllContents(oldValue, false);
+ toRemove.add(object);
+ final TreeIterator<EObject> iterator = EcoreUtil.getAllContents(object, false);
while (iterator.hasNext()) {
toRemove.add(iterator.next());
}
- for (final EObject object : toRemove) {
- cache.remove(object);
+ for (final EObject eObject : toRemove) {
+ cache.remove(eObject);
}
}
- private static Diagnostic getDiagnostic(Object object) {
+ /**
+ * Validate given object and return the result of the validation.
+ *
+ * @param object the object to validate
+ * @return the validation result
+ * @since 1.25
+ */
+ protected static Diagnostic getDiagnostic(Object object) {
if (!EObject.class.isInstance(object)) {
return Diagnostic.OK_INSTANCE;
}
@@ -302,9 +316,16 @@
return diagnostics;
}
- private void notifyValidationListeners(final Set<EObject> update, boolean struc) {
+ /**
+ * Notify the registered validation listeners that a validation occurred.
+ *
+ * @param updatedObjects the objects that changed
+ * @param potentialStructuralChange whether the validation was caused by a structural change
+ * @since 1.25
+ */
+ protected void notifyValidationListeners(final Set<EObject> updatedObjects, boolean potentialStructuralChange) {
for (final ValidationListener validationListener : validationListeners) {
- validationListener.revalidationOccurred(update, struc);
+ validationListener.revalidationOccurred(updatedObjects, potentialStructuralChange);
}
}
