commit a1e4fdc139be8312319289fd71da9c575ca8a78b
author Dimitrios Chalepakis <dimitrios.chalepakis@pta.de> Tue Aug 04 08:40:10 2020 +0200
committer Dimitrios Chalepakis <dimitrios.chalepakis@pta.de> Tue Aug 04 08:40:10 2020 +0200
tree 8579cad4254440d01d8375f68a690a5243642405
parent c95c81de632e1affc80a5b2bb2acf8523ad16100

SI-1036 code review

Signed-off-by: Dimitrios Chalepakis <dimitrios.chalepakis@pta.de>

projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.html

diff --git a/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.html b/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.html
index ed4525b..709b31a 100644
--- a/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.html
+++ b/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.html
@@ -167,10 +167,7 @@
                   name="test"
                   [ngModel]="formState.controls['branchId'].value"
                   (ngModelChange)="
-                    setBrancheValue($event);
-                    gridFailureDetailsSandbox.resetFailureLocationValues();
-                    setLocation();
-                    gridFailureDetailsSandbox.setFormStateDirty()
+                    setBranchValue($event); gridFailureDetailsSandbox.resetFailureLocationValues(); setLocation(); gridFailureDetailsSandbox.setFormStateDirty()
                   "
                   [required]="!gridFailureDetailsSandbox.oldVersion && !formState.isDisabled"
                   type="text"

projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.spec.ts

diff --git a/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.spec.ts b/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.spec.ts
index d3fcb90..e6f1472 100644
--- a/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.spec.ts
+++ b/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.spec.ts
@@ -314,7 +314,7 @@
   it('should set Branch State correctly', () => {
     const spy: any = spyOn(gridFailureSandbox, 'setBranchState');
     component.gridFailureDetailsSandbox.branches = [new FailureBranch()];
-    component.setBrancheValue('id1');
+    component.setBranchValue('id1');
     expect(spy).toHaveBeenCalled();
   });
 

projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.ts

diff --git a/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.ts b/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.ts
index 873573e..7e32035 100644
--- a/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.ts
+++ b/projects/grid-failure-information-app/src/app/pages/grid-failure/grid-failure-details/grid-failure-details.component.ts
@@ -84,7 +84,7 @@
       }
     });
   }
-  public setBrancheValue(branchId: string) {
+  public setBranchValue(branchId: string) {
     const branch = this.gridFailureDetailsSandbox.branches.find(b => b.id === branchId);
     this.gridFailureDetailsSandbox.setBranchState(branch);
   }