| commit | 428cc3497ee844b9262d1bdc7cb09a8332eee87c | [log] [tgz] |
|---|---|---|
| author | Eric Williams <ericwill@redhat.com> | Wed Dec 23 09:55:43 2015 -0500 |
| committer | Alexander Kurtakov <akurtako@redhat.com> | Tue Jan 05 02:56:01 2016 -0500 |
| tree | bd0f792ff71e9d0e4a152337c230d2654e836bce | |
| parent | 461f8521e5dd006476b3691e85a78b86679c3b00 [diff] |
Bug 484696: [GTK] Empty repositories view links have white backgrounds After bug 479998, an empty EGit repositories view still has mismatched label colors. It turns out in this case the background color of the parent composite was incorrect -- it should have been white (like on GTK3.14 and earlier) instead of gray. In this case the parent composite's background color is set to be that of the TreeViewer which will display the future repository branches, information, etc. The default color for Trees/Tables is white. The fixes for bug 479998 and bug 479998 introduced a small regression which set the default color of Table/Trees to be gray. The issue in this case does not lie with the labels but with the color of the parent composite. With Table/Trees returning their proper default background color (white, or COLOR_LIST_BACKGROUND), the EGit label issue is fixed. Tested on GTK3.18.6, 3.16, 3.14, and 2.24. AllNonBrowser JUnit tests pass on GTK3 and GTK2. Change-Id: I47fe95c1ad5fc87411c0f27ff344f6369c9aa0c6 Signed-off-by: Eric Williams <ericwill@redhat.com>
Thanks for your interest in this project.
Information regarding source code management, builds, coding standards, and more.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!