tree 5f961e37cb974154e0fb307fcfa0e98537e9ba99
parent ca8b91a686c34170c9ccb91f1f2a55d6c97748ff
author Carsten Hammer <carsten.hammer@t-online.de> 1607272367 +0100
committer Alexander Kurtakov <akurtako@redhat.com> 1626847271 -0400

Bug: Incorrect lazy initialization of static field

org.eclipse.help.internal.criteria.CriteriaProviderRegistry.instance in
org.eclipse.help.internal.criteria.CriteriaProviderRegistry.getInstance()

This method contains an unsynchronized lazy initialization of a
non-volatile static field. Because the compiler or processor may reorder
instructions, threads are not guaranteed to see a completely initialized
object, if the method can be called by multiple threads. You can make
the field volatile to correct the problem. For more information, see the
Java Memory Model web site.

Rank: Troubling (14), confidence: Normal
Pattern: LI_LAZY_INIT_STATIC
Type: LI, Category: MT_CORRECTNESS (Multithreaded correctness)

Change-Id: Ie3f80610a6bf944971c40108f7c5a0512c7550d4
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/173461
Tested-by: Platform Bot <platform-bot@eclipse.org>
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>