[dogfooding][cleanup] Use static inner class clean up for ui.workbench
code
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: I57a6580b3fd7004893f4baa38da50e1cb5ae4d85
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/179062
Tested-by: Platform Bot <platform-bot@eclipse.org>
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ContentTypesPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ContentTypesPreferencePage.java
index f8c95b4..f9c2fb9 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ContentTypesPreferencePage.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ContentTypesPreferencePage.java
@@ -165,7 +165,7 @@
}
- private class FileSpecComparator extends ViewerComparator {
+ private static class FileSpecComparator extends ViewerComparator {
@Override
public int category(Object element) {
// only Spec objects in here - unchecked cast
@@ -192,7 +192,7 @@
}
}
- private class FileSpecContentProvider implements IStructuredContentProvider {
+ private static class FileSpecContentProvider implements IStructuredContentProvider {
@Override
public Object[] getElements(Object inputElement) {
@@ -251,7 +251,7 @@
}
}
- private class ContentTypesLabelProvider extends LabelProvider {
+ private static class ContentTypesLabelProvider extends LabelProvider {
@Override
public String getText(Object element) {
IContentType contentType = (IContentType) element;
@@ -259,7 +259,7 @@
}
}
- private class ContentTypesContentProvider implements ITreeContentProvider {
+ private static class ContentTypesContentProvider implements ITreeContentProvider {
private IContentTypeManager manager;
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferencePage.java
index 9dcbc8f..e891942 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferencePage.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferencePage.java
@@ -306,7 +306,7 @@
}
- private final class ResortColumn extends SelectionAdapter {
+ private static final class ResortColumn extends SelectionAdapter {
private final BindingModelComparator comparator;
private final TreeColumn treeColumn;
private final TreeViewer viewer;
@@ -429,7 +429,7 @@
}
}
- class ModelContentProvider implements ITreeContentProvider {
+ static class ModelContentProvider implements ITreeContentProvider {
@Override
public Object[] getChildren(Object parentElement) {
if (parentElement instanceof BindingModel) {
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/CategorizedPageRegistryReader.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/CategorizedPageRegistryReader.java
index cc5aa6a..405c403 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/CategorizedPageRegistryReader.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/CategorizedPageRegistryReader.java
@@ -39,7 +39,7 @@
* Internal class used to sort all the preference page nodes based on the
* category.
*/
- abstract class CategoryNode {
+ abstract static class CategoryNode {
/**
* Comment for <code>reader</code>
*/
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/PreferencePageRegistryReader.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/PreferencePageRegistryReader.java
index 1f059c8..5b01cad 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/PreferencePageRegistryReader.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/PreferencePageRegistryReader.java
@@ -38,7 +38,7 @@
private IWorkbench workbench;
- class PreferencesCategoryNode extends CategoryNode {
+ static class PreferencesCategoryNode extends CategoryNode {
WorkbenchPreferenceNode node;
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/PropertyPagesRegistryReader.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/PropertyPagesRegistryReader.java
index 9451496..84aec9b 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/PropertyPagesRegistryReader.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/PropertyPagesRegistryReader.java
@@ -88,7 +88,7 @@
private PropertyPageContributorManager manager;
- class PropertyCategoryNode extends CategoryNode {
+ static class PropertyCategoryNode extends CategoryNode {
RegistryPageContributor page;
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/LogThrottle.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/LogThrottle.java
index f5b9730..6f52d1c 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/LogThrottle.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/LogThrottle.java
@@ -111,7 +111,7 @@
return counter;
}
- private class MutableInt {
+ private static class MutableInt {
private int fCount;
public void increment() {
