commit f3d4c0796c48cc5906ef0e59a966afe60e940eab
author Matthias Villiger <mvi@bsi-software.com> Thu Nov 05 13:45:02 2020 +0100
committer Matthias Villiger <mvi@bsi-software.com> Thu Nov 05 13:45:02 2020 +0100
tree c1f25be7f9c74799c4fbfdf9fcea1df8eeb505f1
parent 7deb2a4d971b8e705993936100336b14befae908

Bug 565896 Maven fails because it installs NPM modules at wrong location

The maven build fails if the @eclipse-scout/releng & pnpm modules are
not installed in the expected node directory below
module/target/node/node_modules. Because the scripts running later on
explicitly use this directory to locate pnpm.js and releng-scripts.js

Therefore use the --prefix option to ensure it is installed in the
expected directory only.
And do not use the frontend-maven-plugin to call npm because the
argument passed to --prefix might contain special characters (e.g. white
spaces) which break the command because the frontend-maven-plugin only
uses one single <arguments> tag for the whole command. Quoting the
prefix path does not work on some operating systems either.
Instead the exec-maven-plugin is used to call npm which allows to pass
every argument in a single <argument> tag which also works if such an
argument contains spaces.

Furthermore do not install globally (-g argument) to ensure the
dependencies are always located directly below node_modules. Because
when installing globally, a "lib" directory might be created on some
operating systems.
See https://docs.npmjs.com/cli/v6/configuring-npm/folders.
This solution removes the requirement for the platform dependent
properties which did not work on all systems anyway.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=565896
See https://www.eclipse.org/forums/index.php/m/1830972

274951