Bug 537322 - Added waiting for jobs in test to prevent log errors
The tests in test case TestToggleBreakpointsTarget will do some
breakpoint operations, make assertions and then clean-up. The breakpoint
operations trigger jobs, which coincide with the clean-up of the test.
This change adds waiting before the clean-up, to avoid the error log
entries. This helps keeping the build log clean, helping to identify
actual problems more easily.
Change-Id: I4d51e6f7d32817134ee01f39c3b7af13cf74a665
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
diff --git a/org.eclipse.jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/breakpoints/TestToggleBreakpointsTarget.java b/org.eclipse.jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/breakpoints/TestToggleBreakpointsTarget.java
index 7da9341..40f2330 100644
--- a/org.eclipse.jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/breakpoints/TestToggleBreakpointsTarget.java
+++ b/org.eclipse.jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/breakpoints/TestToggleBreakpointsTarget.java
@@ -16,6 +16,7 @@
import org.eclipse.jdt.debug.core.IJavaLineBreakpoint;
import org.eclipse.jdt.debug.core.IJavaMethodBreakpoint;
import org.eclipse.jdt.debug.core.IJavaWatchpoint;
+import org.eclipse.jdt.debug.tests.TestUtil;
/**
* Tests the Java debugger's 'toggle breakpoints target'.
@@ -44,6 +45,7 @@
IJavaLineBreakpoint breakpoint = (IJavaLineBreakpoint) added;
assertEquals("Wrong line number", 23, breakpoint.getLineNumber());
assertEquals("Wrong type name", "a.b.c.SomeClass", breakpoint.getTypeName());
+ TestUtil.waitForJobs(getName(), 100, DEFAULT_TIMEOUT);
} finally {
manager.removeBreakpointListener(listener);
removeAllBreakpoints();
@@ -68,6 +70,7 @@
IJavaWatchpoint breakpoint = (IJavaWatchpoint) added;
assertEquals("Wrong type name", "a.b.c.SomeClass", breakpoint.getTypeName());
assertEquals("Wrong field name", "someField", breakpoint.getFieldName());
+ TestUtil.waitForJobs(getName(), 100, DEFAULT_TIMEOUT);
} finally {
manager.removeBreakpointListener(listener);
removeAllBreakpoints();
@@ -95,6 +98,7 @@
// this will actually fail to suspend since 'SomeClass' is not qualified, but we can't resolve the type
// without a build path, etc. (not a regression)
assertEquals("Wrong signature", "(Ljava/lang/String;LSomeClass;)V", breakpoint.getMethodSignature());
+ TestUtil.waitForJobs(getName(), 100, DEFAULT_TIMEOUT);
} finally {
manager.removeBreakpointListener(listener);
removeAllBreakpoints();
