Bug 564063 - Using ArrayContentProvider.getInstance() instead of new
instance
ArrayContentProvider does not hold any data, hence it can be shared
across instances.
Change-Id: I5ff38114fd1f90ae8c797dc3b993dbee2fa98b85
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/ExecutionEnvironmentsPreferencePage.java b/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/ExecutionEnvironmentsPreferencePage.java
index 265dd35..e45346b 100644
--- a/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/ExecutionEnvironmentsPreferencePage.java
+++ b/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/ExecutionEnvironmentsPreferencePage.java
@@ -191,7 +191,7 @@
table.setLayout(layout);
table.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));
fProfilesViewer = new TableViewer(table);
- fProfilesViewer.setContentProvider(new ArrayContentProvider());
+ fProfilesViewer.setContentProvider(ArrayContentProvider.getInstance());
fProfilesViewer.setLabelProvider(new ExecutionEnvironmentsLabelProvider());
fProfilesViewer.setInput(JavaRuntime.getExecutionEnvironmentsManager().getExecutionEnvironments());
diff --git a/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/VMTypePage.java b/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/VMTypePage.java
index 04500a3..b62e1e8 100644
--- a/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/VMTypePage.java
+++ b/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/jres/VMTypePage.java
@@ -116,7 +116,7 @@
data.widthHint = 300;
fTypesViewer.getControl().setFont(composite.getFont());
fTypesViewer.getControl().setLayoutData(data);
- fTypesViewer.setContentProvider(new ArrayContentProvider());
+ fTypesViewer.setContentProvider(ArrayContentProvider.getInstance());
fTypesViewer.setLabelProvider(new TypeLabelProvider());
fTypesViewer.setComparator(new ViewerComparator());
fTypesViewer.addDoubleClickListener(new IDoubleClickListener() {
