Bug 560431 - convert to enhanced for loop may cause build time warnings

- add new cleanup preference in CleanUpConstants:
  CONTROL_STATMENTS_CONVERT_FOR_LOOP_ONLY_IF_LOOP_VAR_USED
- default new cleanup preference to false in CleanUpConstantsOptions
- add new messages for new preference
- add new preference as slave to enhanced for loop conversion in
  CodeStyleTabPage
- pass new preference to ConvertLoopFix and ConvertLoopFixCore and
  ultimately to ConvertForLoopOperation and ConvertIterableLoopOperation
- add new code to ConvertForLoopOperation and
  ConvertIterableLoopOperation to verify the loop variable gets used
  if the new preference is true
- add new tests to CleanUpTest1d5 to verify loops that don't use
  loop variable are not converted when preference is set
- remove ignored test for Bug 560431 from ConvertForLoopQuickFixTest

Change-Id: I0476bf223f0f76fcd112aead4c29ef358942fb52
14 files changed
tree: 9591fa66ca5e60016596dbe666c507f1794115eb
  1. org.eclipse.jdt.astview/
  2. org.eclipse.jdt.astview.feature/
  3. org.eclipse.jdt.core.manipulation/
  4. org.eclipse.jdt.jeview/
  5. org.eclipse.jdt.jeview.feature/
  6. org.eclipse.jdt.junit/
  7. org.eclipse.jdt.junit.core/
  8. org.eclipse.jdt.junit.runtime/
  9. org.eclipse.jdt.junit4.runtime/
  10. org.eclipse.jdt.junit5.runtime/
  11. org.eclipse.jdt.text.tests/
  12. org.eclipse.jdt.ui/
  13. org.eclipse.jdt.ui.examples.javafamily/
  14. org.eclipse.jdt.ui.examples.projects/
  15. org.eclipse.jdt.ui.tests/
  16. org.eclipse.jdt.ui.tests.refactoring/
  17. org.eclipse.ltk.core.refactoring/
  18. org.eclipse.ltk.core.refactoring.tests/
  19. org.eclipse.ltk.ui.refactoring/
  20. org.eclipse.ltk.ui.refactoring.tests/
  21. tests-pom/
  22. .gitignore
  23. CONTRIBUTING
  24. LICENSE
  25. NOTICE
  26. pom.xml
  27. README.md
README.md

Contributing to JDT UI - Java development tools UI

Thanks for your interest in this project.

Project description:

The JDT UI implements the user interface for the Java IDE. This includes views like Package Explorer and JUnit, the Java and properties files editors, Java search, and refactorings. Website: http://www.eclipse.org/jdt/ui/

How to contribute:

Contributions to JDT UI are most welcome. There are many ways to contribute, from entering high quality bug reports, to contributing code or documentation changes. For a complete guide, see the [How to Contribute] 1 page on the team wiki.

Developer resources:

Information regarding source code management, builds, coding standards, and more.

Contributor License Agreement:

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).

Forum:

Public forum for Eclipse JDT users.

Search for bugs:

This project uses Bugzilla to track ongoing development and issues.

Create a new bug:

Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!

Contact:

Contact the project developers via the project's “dev” list.

License

Eclipse Public License (EPL) v2.0