[314109] org.eclipse.jst.ejb.ui.tests needs an about.html file
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/.settings/org.eclipse.jdt.core.prefs b/tests/org.eclipse.jst.ejb.ui.tests/.settings/org.eclipse.jdt.core.prefs
index a9c8a09..19c7dd3 100644
--- a/tests/org.eclipse.jst.ejb.ui.tests/.settings/org.eclipse.jdt.core.prefs
+++ b/tests/org.eclipse.jst.ejb.ui.tests/.settings/org.eclipse.jdt.core.prefs
@@ -1,7 +1,74 @@
-#Mon Sep 01 14:46:14 EEST 2008
+#Wed May 26 14:42:09 EEST 2010
 eclipse.preferences.version=1
+org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
 org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5
+org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
 org.eclipse.jdt.core.compiler.compliance=1.5
+org.eclipse.jdt.core.compiler.debug.lineNumber=generate
+org.eclipse.jdt.core.compiler.debug.localVariable=generate
+org.eclipse.jdt.core.compiler.debug.sourceFile=generate
+org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
 org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
+org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
+org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning
+org.eclipse.jdt.core.compiler.problem.deadCode=warning
+org.eclipse.jdt.core.compiler.problem.deprecation=warning
+org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
+org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
+org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
+org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore
 org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
+org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore
+org.eclipse.jdt.core.compiler.problem.fatalOptionalError=enabled
+org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore
+org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning
+org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning
+org.eclipse.jdt.core.compiler.problem.forbiddenReference=error
+org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning
+org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
+org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=ignore
+org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
+org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
+org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
+org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore
+org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore
+org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
+org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning
+org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore
+org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning
+org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning
+org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning
+org.eclipse.jdt.core.compiler.problem.nullReference=warning
+org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
+org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
+org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore
+org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore
+org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
+org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore
+org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=ignore
+org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
+org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
+org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
+org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
+org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
+org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
+org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore
+org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
+org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
+org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore
+org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=ignore
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled
+org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled
+org.eclipse.jdt.core.compiler.problem.unusedImport=warning
+org.eclipse.jdt.core.compiler.problem.unusedLabel=warning
+org.eclipse.jdt.core.compiler.problem.unusedLocal=warning
+org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore
+org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled
+org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled
+org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
+org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning
+org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
+org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
 org.eclipse.jdt.core.compiler.source=1.5
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.jst.ejb.ui.tests/META-INF/MANIFEST.MF
index 08d2166..33b4666 100644
--- a/tests/org.eclipse.jst.ejb.ui.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.jst.ejb.ui.tests/META-INF/MANIFEST.MF
@@ -1,8 +1,8 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
-Bundle-Name: JST EJB UI tests plugin
+Bundle-Name: %Bundle-Name.0
 Bundle-SymbolicName: org.eclipse.jst.ejb.ui.tests
-Bundle-Version: 1.0.0
+Bundle-Version: 1.0.0.qualifier
 Bundle-Activator: org.eclipse.jst.ejb.ui.tests.Activator
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.jst.ejb.ui;bundle-version="[1.1.201,1.2.0)",
@@ -10,3 +10,4 @@
  org.eclipse.jdt.ui;bundle-version="[3.2.0,4.0.0)"
 Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: J2SE-1.5
+Bundle-Vendor: %Bundle-Vendor.0
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/about.html b/tests/org.eclipse.jst.ejb.ui.tests/about.html
new file mode 100644
index 0000000..2199df3
--- /dev/null
+++ b/tests/org.eclipse.jst.ejb.ui.tests/about.html
@@ -0,0 +1,34 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN">
+<HTML>
+
+<head>
+<title>About</title>
+<meta http-equiv=Content-Type content="text/html; charset=ISO-8859-1">
+</head>
+
+<BODY lang="EN-US">
+
+<H3>About This Content</H3>
+
+<P>June, 2008</P>
+
+<H3>License</H3>
+
+<P>The Eclipse Foundation makes available all content in this plug-in 
+("Content"). Unless otherwise indicated below, the Content is provided to you 
+under the terms and conditions of the Eclipse Public License Version 1.0 
+("EPL"). A copy of the EPL is available at
+<A href="http://www.eclipse.org/org/documents/epl-v10.php">http://www.eclipse.org/org/documents/epl-v10.php</A>. 
+For purposes of the EPL, "Program" will mean the Content.</P>
+
+<P>If you did not receive this Content directly from the Eclipse Foundation, the 
+Content is being redistributed by another party ("Redistributor") and different 
+terms and conditions may apply to your use of any object code in the Content. 
+Check the Redistributor’s license that was provided with the Content. If no such 
+license exists, contact the Redistributor. Unless otherwise indicated below, the 
+terms and conditions of the EPL still apply to any source code in the Content 
+and such source code may be obtained at
+<A href="http://www.eclipse.org/">http://www.eclipse.org/</A>.</P>
+
+</BODY>
+</HTML>
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/build.properties b/tests/org.eclipse.jst.ejb.ui.tests/build.properties
index d1444fe..2437e12 100644
--- a/tests/org.eclipse.jst.ejb.ui.tests/build.properties
+++ b/tests/org.eclipse.jst.ejb.ui.tests/build.properties
@@ -2,4 +2,6 @@
 output.. = bin/
 bin.includes = META-INF/,\
                .,\
-               test.xml
+               test.xml,\
+               plugin.properties,\
+               about.html
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/plugin.properties b/tests/org.eclipse.jst.ejb.ui.tests/plugin.properties
new file mode 100644
index 0000000..9b34ede
--- /dev/null
+++ b/tests/org.eclipse.jst.ejb.ui.tests/plugin.properties
@@ -0,0 +1,13 @@
+###############################################################################
+# Copyright (c) 2005, 2006 IBM Corporation and others.
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Eclipse Public License v1.0
+# which accompanies this distribution, and is available at
+# http://www.eclipse.org/legal/epl-v10.html
+#
+# Contributors:
+#     IBM Corporation - initial API and implementation
+###############################################################################
+# properties file for org.eclipse.wst.sse.core.tests
+Bundle-Vendor.0 = Eclipse Web Tools Platform
+Bundle-Name.0 = JST EJB UI tests plugin
\ No newline at end of file
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/BusinessInterfaceSelectionExtensionTest.java b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/BusinessInterfaceSelectionExtensionTest.java
index 231cfff..0faa248 100644
--- a/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/BusinessInterfaceSelectionExtensionTest.java
+++ b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/BusinessInterfaceSelectionExtensionTest.java
@@ -61,23 +61,23 @@
 
 	public void testSelectJavaxEjbPackage() {
 		MockTypeInfoRequestor requestor = new MockTypeInfoRequestor();
-		requestor.setPackageName("javax.ejb");
+		requestor.setPackageName("javax.ejb"); //$NON-NLS-1$
 		ITypeInfoFilterExtension filter = fixture.getFilterExtension();
 		assertFalse(filter.select(requestor));
 	}
 
 	public void testSelectJavaIOSerizlizablePackage() {
 		MockTypeInfoRequestor requestor = new MockTypeInfoRequestor();
-		requestor.setPackageName("java.io");
-		requestor.setTypeName("Serializable");
+		requestor.setPackageName("java.io"); //$NON-NLS-1$
+		requestor.setTypeName("Serializable"); //$NON-NLS-1$
 		ITypeInfoFilterExtension filter = fixture.getFilterExtension();
 		assertFalse(filter.select(requestor));
 	}
 
 	public void testSelectJavaIOExternalizablePackage() {
 		MockTypeInfoRequestor requestor = new MockTypeInfoRequestor();
-		requestor.setPackageName("java.io");
-		requestor.setTypeName("Externalizable");
+		requestor.setPackageName("java.io"); //$NON-NLS-1$
+		requestor.setTypeName("Externalizable"); //$NON-NLS-1$
 		ITypeInfoFilterExtension filter = fixture.getFilterExtension();
 		assertFalse(filter.select(requestor));
 	}
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/Activator.java b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/Activator.java
index 7f3bfe1..5aed577 100644
--- a/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/Activator.java
+++ b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/Activator.java
@@ -19,7 +19,7 @@
 public class Activator extends Plugin {
 
 	// The plug-in ID
-	public static final String PLUGIN_ID = "org.eclipse.jst.ejb.ui.tests";
+	public static final String PLUGIN_ID = "org.eclipse.jst.ejb.ui.tests"; //$NON-NLS-1$
 
 	// The shared instance
 	private static Activator plugin;
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/AllTests.java b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/AllTests.java
index 218bd9c..50fc2e6 100644
--- a/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/AllTests.java
+++ b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/AllTests.java
@@ -10,6 +10,8 @@
  ***********************************************************************/
 package org.eclipse.jst.ejb.ui.tests;
 
+import org.eclipse.osgi.util.NLS;
+
 import junit.framework.Test;
 import junit.framework.TestSuite;
 
@@ -20,7 +22,7 @@
 public class AllTests {
 
 	public static Test suite() {
-		TestSuite suite = new TestSuite("Test for org.eclipse.jst.ejb.ui.tests");
+		TestSuite suite = new TestSuite(NLS.bind(Messages.TestSuiteTitle, Activator.PLUGIN_ID));
 		//$JUnit-BEGIN$
 		suite.addTestSuite(org.eclipse.jst.ejb.ui.BusinessInterfaceSelectionExtensionTest.class);
 		//$JUnit-END$
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/Messages.java b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/Messages.java
new file mode 100644
index 0000000..d9179a6
--- /dev/null
+++ b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/Messages.java
@@ -0,0 +1,16 @@
+package org.eclipse.jst.ejb.ui.tests;
+
+import org.eclipse.osgi.util.NLS;
+
+public class Messages extends NLS {
+	private static final String BUNDLE_NAME = "org.eclipse.jst.ejb.ui.tests.messages"; //$NON-NLS-1$
+	static {
+		// initialize resource bundle
+		NLS.initializeMessages(BUNDLE_NAME, Messages.class);
+	}
+
+	private Messages() {
+	}
+
+	public static String TestSuiteTitle;
+}
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/messages.properties b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/messages.properties
new file mode 100644
index 0000000..a35bcae
--- /dev/null
+++ b/tests/org.eclipse.jst.ejb.ui.tests/src/org/eclipse/jst/ejb/ui/tests/messages.properties
@@ -0,0 +1 @@
+TestSuiteTitle=Test for {0}
diff --git a/tests/org.eclipse.jst.ejb.ui.tests/test.xml b/tests/org.eclipse.jst.ejb.ui.tests/test.xml
index c763e38..f11aec0 100644
--- a/tests/org.eclipse.jst.ejb.ui.tests/test.xml
+++ b/tests/org.eclipse.jst.ejb.ui.tests/test.xml
@@ -1,66 +1,112 @@
 <?xml version="1.0" encoding="UTF-8"?>
-
 <project
     name="testsuite"
     default="run"
     basedir=".">
-    
-    <!-- The following properties should be passed into this script -->
-    <!-- ${eclipse-home}   -->
-    <!-- ${buildDirectory}  -->
-    <!-- ${buildLabel}        -->
 
-    <!-- should be little need to change what's above  -->
+    <!-- 
+         ===================================================== 
+         There should be no need to change what's above.
+         (if there is, let us know if the script can be improved.)
+         ===================================================== 
+    -->
     
-	<property
-		name="plugin-name"
-		value="org.eclipse.jst.ejb.ui.tests" />
+    <!-- 
+         Every suite needs to specify three thing: 
+             plugin-name, 
+             classname - that provides the suite to test, and 
+             testType - either core-test, or ui-test. 
+         There is an optional extraVMargs property that some tests need to use in order to specify  
+         extra, non-standard properties to the VM when it runs. If not need, no need to specify it. 
+    -->
+    <property
+        name="plugin-name"
+        value="org.eclipse.jst.ejb.ui.tests" />
     <property
         name="classname"
         value="org.eclipse.jst.ejb.ui.tests.AllTests" />
     <property
         name="testType"
         value="ui-test" />
+    
+    <!-- some test suites need to add special vm arguments when they run. This is just an example.
+    <property
+        name="extraVMargs"
+        value="-DjsfRuntimeJarsDirectoryV1.1=${testDir}/${jsf1.1Dir}" />
+    <echo
+        message="extraVMargs ${extraVMargs}" />
+    -->
 
-    <!-- should be little need to change what's below -->
-
-    <echo message="basedir: ${basedir}" />
-    <echo message="eclipse-home: ${eclipse-home}" />
-    <echo message="buildDirectory: ${buildDirectory}" />
-    <echo message="plugin-name: ${plugin-name}" />
-    <echo message="classname: ${classname}" />
-    <echo message="testType ${testType}" />
-
-
+    <!-- 
+         ===================================================== 
+         There should be no need to change what's below.
+         (if there is, let us know if the script can be improved.)
+         ===================================================== 
+    -->
+    
+    <!-- 
+         There are some properties that must be provided by caller. 
+    -->
+    <fail
+        message="Error: missing property. eclipse-home must be provided"
+        unless="eclipse-home" />
+    <fail
+        message="Error: missing property. buildDirectory must be provided"
+        unless="buildDirectory" />
+    <fail
+        message="Error: missing property. buildLabel must be provided"
+        unless="buildLabel" />
+    <echo
+        message="basedir: ${basedir}" />
+    <echo
+        message="eclipse-home: ${eclipse-home}" />
+    <echo
+        message="buildDirectory: ${buildDirectory}" />
+    <echo
+        message="plugin-name: ${plugin-name}" />
+    <echo
+        message="classname: ${classname}" />
+    <echo
+        message="testType ${testType}" />
     <property
         name="library-file"
         value="${eclipse-home}/plugins/org.eclipse.test_3.1.0/library.xml" />
     <property
         name="workspace"
         value="${eclipse-home}/junitworkspaces/${plugin-name}" />
-        
-    <!-- This target holds all initialization code that needs to be done for -->
-    <!-- all tests that are to be run. Initialization for individual tests -->
-    <!-- should be done within the body of the suite target. -->
-    <target name="init">
+
+      <!-- 
+    This init target holds all initialization code that needs to be done for
+      all tests that are to be run. Initialization for individual tests
+      should be done within the body of the suite target. Here it's a good idea 
+    to delete things that might have been created if the test has already been 
+    ran, just in case the test is being re-ran. 
+    -->
+    <target
+        name="init">
         <tstamp />
         <delete>
             <fileset
                 dir="${eclipse-home}"
                 includes="${plugin-name}.*xml" />
         </delete>
-        <!-- make directory, in case path doesn't exist yet -->
-        <mkdir dir="${workspace}" />
-        <!--  but delete to make sure fresh contents-->
+        
+            <!-- 
+         make the workspace directory, in case path doesn't exist yet
+         but delete to make sure fresh contents, if it does exist
+        -->
         <delete
             dir="${workspace}"
             quiet="true" />
-
+        <mkdir
+            dir="${workspace}" />
     </target>
 
-    <!-- This target defines the tests that need to be run. -->
-    <target name="suite">
-
+    <!-- 
+      This suite target defines the tests that need to be run.
+    -->
+    <target
+        name="suite">
         <ant
             target="${testType}"
             antfile="${library-file}"
@@ -78,24 +124,31 @@
                 name="plugin-path"
                 value="${eclipse-home}/plugins/${plugin-name}" />
         </ant>
-
         <copy
             failonerror="false"
             file="${workspace}/.metadata/.log"
             tofile="${buildDirectory}/${buildLabel}/testResults/consolelogs/${plugin-name}.consolelog.txt" />
+    </target>
+
+     <!-- 
+     This clean target holds code to cleanup the testing environment after
+     after all of the tests have been run. You can use this target to 
+     delete temporary files that have been created, if required. But, 
+     it's usually best to leave it all, in case you'd like to inspect it 
+     after a failed run. It will be deleted eventually by the next clean build. 
+    -->
+    <target
+        name="cleanup">
 
     </target>
 
-    <!-- This target holds code to cleanup the testing environment after -->
-    <!-- after all of the tests have been run. You can use this target to -->
-    <!-- delete temporary files that have been created. -->
-    <target name="cleanup">
-        <!-- usually no need to delete workspace until next run, and leaving it allows inspection -->
-        <!-- <delete dir="${workspace}" quiet="true" /> -->
-    </target>
-
-    <!-- This target runs the test suite. Any actions that need to happen -->
-    <!-- after all the tests have been run should go here. -->
+    <!-- 
+       This run target is the master target that get's all the work done. 
+       Most activity is actually done in the 'depends' tasks, but any 
+       actions that need to happen after all the tests have been run 
+       should go here, such as copying the results to a common 'save' 
+       directory. 
+    -->
     <target
         name="run"
         depends="init,suite,cleanup">
@@ -111,5 +164,4 @@
                 value="${plugin-name}.xml" />
         </ant>
     </target>
-
 </project>
\ No newline at end of file