More compiler warnings fixes.
And save actions to automate things.
Change-Id: I5cb312b10642617c11fb62ed0f1260a3fab14b14
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/c/linuxtools/org.eclipse.linuxtools/+/166572
Tested-by: Linux Tools Bot <linuxtools-bot@eclipse.org>
diff --git a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/internal/docker/core/DockerImage.java b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/internal/docker/core/DockerImage.java
index 6192fdf..7670fac 100644
--- a/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/internal/docker/core/DockerImage.java
+++ b/containers/org.eclipse.linuxtools.docker.core/src/org/eclipse/linuxtools/internal/docker/core/DockerImage.java
@@ -1,6 +1,6 @@
/*******************************************************************************
* Copyright (c) 2014, 2018 Red Hat.
- *
+ *
* This program and the accompanying materials are made
* available under the terms of the Eclipse Public License 2.0
* which is available at https://www.eclipse.org/legal/epl-2.0/
@@ -50,7 +50,7 @@
+ "(\\:(?<tag>" + TAG + "))?"); //$NON-NLS-1$ //$NON-NLS-2$
// SimpleDateFormat is not thread-safe, so give one to each thread
- private static final ThreadLocal<SimpleDateFormat> formatter = new ThreadLocal<SimpleDateFormat>() {
+ private static final ThreadLocal<SimpleDateFormat> formatter = new ThreadLocal<>() {
@Override
protected SimpleDateFormat initialValue() {
return new SimpleDateFormat("yyyy-MM-dd"); //$NON-NLS-1$
@@ -141,7 +141,7 @@
* {@code repoTags}, assuming that the given repoTags elements have the
* following format: {@code [org/]repo[:tag]}. Tags are sorted by their
* natural order.
- *
+ *
* @param repoTags
* the list of repo/tags to analyze
* @return the tags indexed by org/repo
@@ -170,7 +170,7 @@
/**
* Extracts the list of tags in the given repo/tags, assuming that the given
* repoTags elements have the following format: {@code [org/]repo[:tag]}.
- *
+ *
* @param repoTags
* the repo/tags list to analyze
* @return the list of tags or empty list if none was found.
@@ -194,7 +194,7 @@
/**
* Extracts the tag in the given repo/tag, assuming that the given repoTag
* element has the following format: {@code [org/]repo[:tag]}.
- *
+ *
* @param repoTag
* the repo/tag to analyze
* @return the tag or null if none was found.
@@ -213,7 +213,7 @@
/**
* Extracts the tag in the given repo/tag, assuming that the given repoTag
* element has the following format: {@code [org/]repo[:tag]}
- *
+ *
* @param repoTag
* the repo/tag to analyze
* @return the tag or <code>null</code> if none was found.
@@ -232,7 +232,7 @@
/**
* Duplicates the given {@code image} into as many {@link IDockerImage} has
* it has distinct repoTags entries
- *
+ *
* @param image
* the source image
* @return a {@link Stream} of duplicate {@link IDockerImage}
@@ -373,7 +373,7 @@
/**
* Appends the <code>latest</code> tag to the given {@code imageName}
- *
+ *
* @param imageName
* the image name to check
* @return the image name with the <code>latest</code> tag if none was set
diff --git a/man/org.eclipse.linuxtools.man.help/.settings/org.eclipse.jdt.ui.prefs b/man/org.eclipse.linuxtools.man.help/.settings/org.eclipse.jdt.ui.prefs
index c43046c..1080c83 100644
--- a/man/org.eclipse.linuxtools.man.help/.settings/org.eclipse.jdt.ui.prefs
+++ b/man/org.eclipse.linuxtools.man.help/.settings/org.eclipse.jdt.ui.prefs
@@ -1,4 +1,3 @@
-#Wed Dec 09 21:56:11 EET 2009
eclipse.preferences.version=1
editor_save_participant_org.eclipse.jdt.ui.postsavelistener.cleanup=true
formatter_profile=org.eclipse.jdt.ui.default.eclipse_profile
@@ -14,33 +13,46 @@
sp_cleanup.add_missing_methods=false
sp_cleanup.add_missing_nls_tags=false
sp_cleanup.add_missing_override_annotations=true
+sp_cleanup.add_missing_override_annotations_interface_methods=true
sp_cleanup.add_serial_version_id=false
sp_cleanup.always_use_blocks=true
sp_cleanup.always_use_parentheses_in_expressions=false
sp_cleanup.always_use_this_for_non_static_field_access=false
sp_cleanup.always_use_this_for_non_static_method_access=false
-sp_cleanup.convert_to_enhanced_for_loop=false
+sp_cleanup.convert_functional_interfaces=true
+sp_cleanup.convert_to_enhanced_for_loop=true
+sp_cleanup.convert_to_enhanced_for_loop_if_loop_var_used=false
sp_cleanup.correct_indentation=false
sp_cleanup.format_source_code=true
sp_cleanup.format_source_code_changes_only=false
+sp_cleanup.insert_inferred_type_arguments=false
+sp_cleanup.lazy_logical_operator=false
sp_cleanup.make_local_variable_final=false
sp_cleanup.make_parameters_final=false
sp_cleanup.make_private_fields_final=true
sp_cleanup.make_type_abstract_if_missing_method=false
sp_cleanup.make_variable_declarations_final=false
+sp_cleanup.merge_conditional_blocks=false
sp_cleanup.never_use_blocks=false
sp_cleanup.never_use_parentheses_in_expressions=true
+sp_cleanup.number_suffix=false
+sp_cleanup.objects_equals=false
sp_cleanup.on_save_use_additional_actions=true
sp_cleanup.organize_imports=true
+sp_cleanup.push_down_negation=false
sp_cleanup.qualify_static_field_accesses_with_declaring_class=false
sp_cleanup.qualify_static_member_accesses_through_instances_with_declaring_class=true
sp_cleanup.qualify_static_member_accesses_through_subtypes_with_declaring_class=true
sp_cleanup.qualify_static_member_accesses_with_declaring_class=false
sp_cleanup.qualify_static_method_accesses_with_declaring_class=false
sp_cleanup.remove_private_constructors=true
+sp_cleanup.remove_redundant_modifiers=true
+sp_cleanup.remove_redundant_semicolons=true
+sp_cleanup.remove_redundant_type_arguments=true
sp_cleanup.remove_trailing_whitespaces=false
sp_cleanup.remove_trailing_whitespaces_all=true
sp_cleanup.remove_trailing_whitespaces_ignore_empty=false
+sp_cleanup.remove_unnecessary_array_creation=true
sp_cleanup.remove_unnecessary_casts=true
sp_cleanup.remove_unnecessary_nls_tags=true
sp_cleanup.remove_unused_imports=true
@@ -49,12 +61,19 @@
sp_cleanup.remove_unused_private_members=false
sp_cleanup.remove_unused_private_methods=true
sp_cleanup.remove_unused_private_types=true
+sp_cleanup.simplify_lambda_expression_and_method_ref=true
sp_cleanup.sort_members=false
sp_cleanup.sort_members_all=false
+sp_cleanup.use_anonymous_class_creation=false
+sp_cleanup.use_autoboxing=false
sp_cleanup.use_blocks=false
sp_cleanup.use_blocks_only_for_return_and_throw=false
+sp_cleanup.use_directly_map_method=true
+sp_cleanup.use_lambda=true
sp_cleanup.use_parentheses_in_expressions=false
sp_cleanup.use_this_for_non_static_field_access=false
sp_cleanup.use_this_for_non_static_field_access_only_if_necessary=true
sp_cleanup.use_this_for_non_static_method_access=false
sp_cleanup.use_this_for_non_static_method_access_only_if_necessary=true
+sp_cleanup.use_unboxing=false
+sp_cleanup.use_var=false
diff --git a/man/org.eclipse.linuxtools.man.help/src/org/eclipse/linuxtools/internal/man/help/ManualToc.java b/man/org.eclipse.linuxtools.man.help/src/org/eclipse/linuxtools/internal/man/help/ManualToc.java
index eb85878..02f9c66 100644
--- a/man/org.eclipse.linuxtools.man.help/src/org/eclipse/linuxtools/internal/man/help/ManualToc.java
+++ b/man/org.eclipse.linuxtools.man.help/src/org/eclipse/linuxtools/internal/man/help/ManualToc.java
@@ -57,7 +57,7 @@
private void generateSections() {
// Filter to make sure we only get manual section directories
- DirectoryStream.Filter<Path> filter = new DirectoryStream.Filter<Path>() {
+ DirectoryStream.Filter<Path> filter = new DirectoryStream.Filter<>() {
private final Pattern p = Pattern.compile("^man\\d[xp]?"); //$NON-NLS-1$
@Override
