Sonarwork
diff --git a/src/main/java/org/eclipse/openk/contactbasedata/api/AuthNAuthApi.java b/src/main/java/org/eclipse/openk/contactbasedata/api/AuthNAuthApi.java index 9d79918..2f852bd 100644 --- a/src/main/java/org/eclipse/openk/contactbasedata/api/AuthNAuthApi.java +++ b/src/main/java/org/eclipse/openk/contactbasedata/api/AuthNAuthApi.java
@@ -19,10 +19,11 @@ import org.eclipse.openk.contactbasedata.model.LoginCredentials; import org.eclipse.openk.contactbasedata.viewmodel.UserModule; import org.springframework.cloud.openfeign.FeignClient; -import org.springframework.http.ResponseEntity; -import org.springframework.web.bind.annotation.*; +import org.springframework.web.bind.annotation.GetMapping; +import org.springframework.web.bind.annotation.PostMapping; +import org.springframework.web.bind.annotation.RequestBody; +import org.springframework.web.bind.annotation.RequestHeader; -import javax.xml.ws.Response; import java.util.List; @FeignClient(name = "${services.authNAuth.name}")
diff --git a/src/main/java/org/eclipse/openk/contactbasedata/config/LdapSchedulerConfig.java b/src/main/java/org/eclipse/openk/contactbasedata/config/LdapSchedulerConfig.java index a3b3c78..cb9b953 100644 --- a/src/main/java/org/eclipse/openk/contactbasedata/config/LdapSchedulerConfig.java +++ b/src/main/java/org/eclipse/openk/contactbasedata/config/LdapSchedulerConfig.java
@@ -9,8 +9,6 @@ import org.springframework.context.annotation.Configuration; import org.springframework.scheduling.annotation.EnableScheduling; import org.springframework.scheduling.annotation.Scheduled; -import org.springframework.scheduling.annotation.SchedulingConfigurer; -import org.springframework.scheduling.config.ScheduledTaskRegistrar; @Log4j2 @Configuration
diff --git a/src/main/java/org/eclipse/openk/contactbasedata/controller/AuthNAuthController.java b/src/main/java/org/eclipse/openk/contactbasedata/controller/AuthNAuthController.java index e69b82f..bbea729 100644 --- a/src/main/java/org/eclipse/openk/contactbasedata/controller/AuthNAuthController.java +++ b/src/main/java/org/eclipse/openk/contactbasedata/controller/AuthNAuthController.java
@@ -14,14 +14,11 @@ */ package org.eclipse.openk.contactbasedata.controller; -import com.fasterxml.jackson.core.JsonProcessingException; import io.swagger.annotations.ApiOperation; import io.swagger.annotations.ApiResponse; import io.swagger.annotations.ApiResponses; import lombok.extern.log4j.Log4j2; import org.eclipse.openk.contactbasedata.service.AuthNAuthService; -import org.eclipse.openk.contactbasedata.service.LdapService; -import org.eclipse.openk.contactbasedata.viewmodel.LdapUser; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.http.HttpStatus; import org.springframework.http.ResponseEntity; @@ -30,9 +27,6 @@ import org.springframework.web.bind.annotation.ResponseStatus; import org.springframework.web.bind.annotation.RestController; -import java.net.URISyntaxException; -import java.util.List; - @Log4j2 @RestController @RequestMapping("/authnauth") @@ -45,7 +39,7 @@ @ApiResponses(value = {@ApiResponse(code = 200, message = "Erfolgreich durchgeführt")}) @ResponseStatus(HttpStatus.OK) @GetMapping( "/loginTest") - public ResponseEntity<Object> loginTest() throws URISyntaxException, JsonProcessingException { + public ResponseEntity<Object> loginTest() { authNAuthService.synchronizeAuthNAuth(); return ResponseEntity.ok().build(); }
diff --git a/src/main/java/org/eclipse/openk/contactbasedata/service/CompanyService.java b/src/main/java/org/eclipse/openk/contactbasedata/service/CompanyService.java index 1f76b0e..a1bf356 100644 --- a/src/main/java/org/eclipse/openk/contactbasedata/service/CompanyService.java +++ b/src/main/java/org/eclipse/openk/contactbasedata/service/CompanyService.java
@@ -141,7 +141,6 @@ private void mapEmail( ContactPersonDto dto, Map<UUID, TblContactPerson> cpMap ) { - // TODO: Move to Mapper TblCommunication tblComm = cpMap.get(dto.getContactUuid()).getContact() .getCommunications().stream() .filter(comm -> comm.getRefCommunicationType().isTypeEmail())
diff --git a/src/main/java/org/eclipse/openk/contactbasedata/service/ContactPersonService.java b/src/main/java/org/eclipse/openk/contactbasedata/service/ContactPersonService.java index 05adbda..35b9f72 100644 --- a/src/main/java/org/eclipse/openk/contactbasedata/service/ContactPersonService.java +++ b/src/main/java/org/eclipse/openk/contactbasedata/service/ContactPersonService.java
@@ -117,7 +117,6 @@ .filter(comm -> comm.getRefCommunicationType().isTypeEmail()) .findFirst().orElse(null); - // TODO: Move to Mapper destDto.setEmail(tblComm != null ? tblComm.getCommunicationData() : null ); return destDto;
diff --git a/src/main/java/org/eclipse/openk/contactbasedata/service/UserService.java b/src/main/java/org/eclipse/openk/contactbasedata/service/UserService.java index 1d946ca..a5a1408 100644 --- a/src/main/java/org/eclipse/openk/contactbasedata/service/UserService.java +++ b/src/main/java/org/eclipse/openk/contactbasedata/service/UserService.java
@@ -18,7 +18,6 @@ import org.eclipse.openk.contactbasedata.model.KeyCloakUser; import org.eclipse.openk.contactbasedata.viewmodel.UserModule; import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.beans.factory.annotation.Value; import org.springframework.security.core.context.SecurityContextHolder; import org.springframework.stereotype.Service;