|author||Evgeny Mandrikov <firstname.lastname@example.org>||Tue May 17 00:10:16 2022 +0200|
|committer||Jonah Graham <email@example.com>||Tue May 17 14:05:10 2022 -0400|
Use ASM 9.3 for JaCoCo 0.8.8 In general case update of bnd recipe is not enough, because ASM is shaded into JaCoCo Agent, so JaCoCo release will be needed. However in this particular case JaCoCo Agent 0.8.8 doesn't need any changes from https://gitlab.ow2.org/asm/asm/-/compare/ASM_9_2...ASM_9_3 not even https://gitlab.ow2.org/asm/asm/-/commit/1597a6029c2db8252ed3362fc7c7b8b4c25b8e8e to have the same behavior with ASM 9.2 as with ASM 9.3, thanks to https://github.com/jacoco/jacoco/blob/v0.8.8/org.jacoco.core/src/org/jacoco/core/internal/instr/InstrSupport.java#L266-L283 Bug: 574539 Change-Id: I4a0c2ade24106cd40cf2d8d3ef12c650e0540ca0
This repositories hosts recipes for building OSGi bundles as part of the Eclipse Orbit project. This repository is based on functionality provided by the Eclipse EBR project.
See Adding Bundles To Orbit in 5 Minutes as a quick explanation of the contribution process.
This project uses Maven for assembling of OSGi bundles based on artifacts in Maven Central or any other accessible Maven repository.
mvn clean install
This will publish all OSGi bundles produced by the recipes into your local Maven repository. You can consume the bundles directly from Maven in any Tycho build.
mvn clean install -f releng/aggregationfeature/pom.xml
mvn clean package -f releng/repository/pom.xml
The repository will be made available as archive in
Note, you must build the recipes first and install the result into your local Maven repository. Otherwise the p2 build won't find any bundles.
This is not difficult at all. Just change into the directory of the recipe to build and execute Maven from there.
mvn clean package
(To preview local changes, add -DdirtyWorkingTree=warning to ignore uncommitted Git changes - see “How to add recipes” for more details)
The resulting bundle will be available in the recipes
Adding recipes to this repository is part of the general process for adding bundles to Orbit. Please read the following additional information first before you proceed.
It‘s important to ensure that the bundle you’re adding has been approved for use in at least one other Eclipse project on IPZilla or ClearlyDefined. In the latter case, please ensure the license is compatible and that the license score is at least 60. See IP Prereq Diligence for further details.
Recipes are organized in folders by category. There is no strict rule on categories, i.e. categories do not map to vendor names by definition. However, it seems logical to select a category name based on some common critaria shared by recipies. Most of the time, “origin” of the 3rd party libraries seems like a good fit. But occasionally, functionality (eg, ‘logging’) is also helpful in order to avoid too fine grained grouping (eg., categories with only two recipies).
In case of doubts/questions, please reach out to the Orbit Committers List. Also, don‘t be afraid of mistakes. It’s all in a single Git repository so re-organization is possible at any time later on.
Note, when creating a new category please create the category pom.xml first before any recipes. Use another category pom.xml as template to inherit the proper Orbit recipe parent pom. This ensure that proper Orbit defaults are used when creating recipes (for example, the bundle vendor is automatically set to “Eclipse Orbit”).
The preferred method for creating recipes is by consuming a Maven artifact. The EBR Maven plug-in can be used to create a recipe including required Eclipse IP information based on data available in Maven artifact poms.
# create the recipe for a specific Maven artifact # the recipe will be created in a folder named "<symbolicname-of-the-orbit-bundle>_<version>" mvn ebr:create-recipe -DgroupId=<maven-source-groupId> -DartifactId=<maven-source-artifactId> -Dversion=<maven-source-version> -DbundleSymbolicName=<symbolicname-of-the-orbit-bundle> # modify recipe pom and osgi.bnd to suit the needs of the bundle cd <new-recipe-folder> $EDITOR pom.xml $EDITOR osgi.bnd # do a test build (this will create a default ip_log.xml) # (note the -DirtyWorkingTree=ignore to ignore uncommitted Git changes for now) mvn -U clean package -DdirtyWorkingTree=warning # hidden gem: automatically create a CQ for an Eclipse project # (use carefully, creates the CQ if none is referenced in the ip_log.xml file) # mvn -V clean package -DsubmitCqsToProject=<Eclipse.project.id> -DcqCryptography=<Yes|No|Unknown|Explanation> -DdirtyWorkingTree=warning # (once the CQ is created, source to upload can be found in 'target/sources-for-eclipse-ipzilla') # (after uploading the source, wait for approval) # enter any non-PB CQ number into the IP log and add any missing information (your name, e-mail etc.) # You may also specify a ClearlyDefined URL (if present) by replacing the <ipzilla bug_id=""/> with <clearlydefined url="https://clearlydefined.io/definitions/maven/mavencentral/com.example.group/artifact/x.y.z" (of course replacing the URL with the appropriate one for the bundle you're adding) $EDITOR src/eclipse/ip_log.xml # review the generated about files ls -la src/main/resources/about_files cat src/main/resources/about.html # add new recipe to category pom $EDITOR ../pom.xml # update the build feature with your bundle $EDITOR ../../releng/aggregationfeature/feature.xml # add, commit the recipe to Git and push to Gerrit for review git add .; git commit -m "Added org.example.foo 1.2.3" # NOTE: Please ensure you push using the following command so that you don't bypass the code review: git push origin HEAD:refs/for/master
If you are having trouble with the build after submitting your change, this is typically because there is a missing dependency. It is ideal to have all transitive dependencies of the library you‘re adding available as OSGi bundles in Orbit, though there may be exceptions to this. The dependency metadata can all be customized using the osgi.bnd file. You can discover the dependencies using
mvn dependency:tree under the project folder of the library you’re adding.