Bug 347417 - [client] Add a confirmation dialog where we want to delete
something
diff --git a/bundles/org.eclipse.orion.client.core/static/js/favorites.js b/bundles/org.eclipse.orion.client.core/static/js/favorites.js
index 6394812..c098e96 100644
--- a/bundles/org.eclipse.orion.client.core/static/js/favorites.js
+++ b/bundles/org.eclipse.orion.client.core/static/js/favorites.js
@@ -194,6 +194,7 @@
 			id: "eclipse.deleteFave",
 			visibleWhen: function(item) {return item.isFavorite;},
 			callback: function(item) {
+				if(confirm("Do you want to remove " + item.name + " from favorites?"))
 				options.serviceRegistry.getService("orion.core.favorite").then(function(service) {
 					service.removeFavorite(item.path);
 				});
@@ -214,6 +215,7 @@
 			id: "eclipse.deleteSearch",
 			visibleWhen: function(item) {return item.isSearch;},
 			callback: function(item) {
+				if(confirm("Do you want to remove " + item.name + " from favorites?"))
 				options.serviceRegistry.getService("orion.core.favorite").then(function(service) {
 					service.removeSearch(item.query);
 				});
diff --git a/bundles/org.eclipse.orion.client.git/static/git/js/gitCommands.js b/bundles/org.eclipse.orion.client.git/static/git/js/gitCommands.js
index ca61824..f0a0bd1 100644
--- a/bundles/org.eclipse.orion.client.git/static/git/js/gitCommands.js
+++ b/bundles/org.eclipse.orion.client.git/static/git/js/gitCommands.js
@@ -252,6 +252,7 @@
 			image: "/images/remove.gif",

 			id: "eclipse.removeBranch",

 			callback: function(item) {

+				if(confirm("Are you sure you want to remove branch " + item.Name+"?"))

 				serviceRegistry.getService("orion.git.provider").then(

 					function(service) {

 						service.removeBranch(item.Location).then(

@@ -296,6 +297,7 @@
 			image: "/images/remove.gif",

 			id: "eclipse.removeRemote",

 			callback: function(item) {

+				if(confirm("Are you sure you want to remove remote " + item.Name+"?"))

 				serviceRegistry.getService("orion.git.provider").then(

 					function(service) {

 						service.removeRemote(item.Location).then(