| commit | cccc768efd31a096b05636eb195ed2966d59ad1b | [log] [tgz] |
|---|---|---|
| author | Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> | Wed Feb 02 20:22:48 2022 +0300 |
| committer | Niraj Modi <niraj.modi@in.ibm.com> | Fri Feb 04 02:57:24 2022 -0500 |
| tree | 532b0d3c53be7c2797bd0b068f02ceb2c68230ee | |
| parent | 1a408f0b8407fac42e133fbb7784a17cdfff8621 [diff] |
Bug 578519 - [win32] Enforce CRLF in .bat scripts If someone (such as me) has git configured with 'core.autocrlf' other then 'true', then SWT's .bat files will have LF file endings. There is a bug with .bat scripts saved with LF line endings, where it incorrectly finds labels for CALL, if the label is on 512 bytes boundary from CALL itself. The problem has been observed many times already: https://www.dostips.com/forum/viewtopic.php?t=8988 https://issues.jenkins-ci.org/browse/JENKINS-9528 https://stackoverflow.com/questions/232651 I also hit this problem while working on the patch for this Bug. For example, the following batch script unexpectedly prints "Ending" on the first line, when saved with LF line endings: -------- @ECHO OFF CALL :Test REM 5678901234567890123456789012345678901234567890 REM 5678901234567890123456789012345678901234567890 REM 5678901234567890123456789012345678901234567890 REM 5678901234567890123456789012345678901234567890 REM 5678901234567890123456789012345678901234567890 REM 5678901234567890123456789012345678901234567890 REM 5678901234567890123456789012345678901234567890 REM 5678901234567890123456789012345678901234567890 REM 5678901234567890123456789012345678901234567890 REM 56789012345678901234567890123456789012345678 CALL :Test ECHO Ending GOTO :EOF :Test ECHO Function GOTO :EOF -------- The solution is to force .bat files to have CRLF line endings. Change-Id: I9beb12a417ea843f16bd239c464a1636e27f4d9e Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/190331 Tested-by: Niraj Modi <niraj.modi@in.ibm.com> Reviewed-by: Niraj Modi <niraj.modi@in.ibm.com>
Thanks for your interest in this project.
See the following description for how to contribute a feature or a bug fix to SWT.
Information regarding source code management, builds, coding standards, and more and be found under the following link.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Contact the project developers via the project's “dev” list.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!