Bug 567258 - [GTK4] Convert Menus, GtkMenuBar, MenuItems to
GtkPopoverMenuBar

- Add GTK4 guard on setImage in MenuItem. As of GTK4, menu images with
text is not supported. It is either an icon, or text.

- Removed unnecessary boxHandle != 0 check in setImage. It is
unnecessary because the only situation where boxHandle == 0 is when the
MenuItem's style is SWT.SEPARATOR, which is checked at the beginning of
the function

- Removed error thrown when boxHandle == 0, since we aren't creating any
new boxes + the same reasoning as removing the check

Change-Id: I2f36debb86aaafd750f042d625af68db36227673
Signed-off-by: Paul D'Pong <sdamrong@redhat.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/178993
Tested-by: Platform Bot <platform-bot@eclipse.org>
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
1 file changed
tree: 16f219b7c11598a62f5262c5284437f1d382a7f1
  1. .gitignore
  2. CONTRIBUTING
  3. LICENSE
  4. NOTICE
  5. README.md
  6. bundles/
  7. container/
  8. examples/
  9. features/
  10. local-build/
  11. pom.xml
  12. tests/
README.md

Contributing to SWT

Thanks for your interest in this project.

Developer resources:

See the following description for how to contribute a feature or a bug fix to SWT.

Information regarding source code management, builds, coding standards, and more and be found under the following link.

Contributor License Agreement:

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).

Contact:

Contact the project developers via the project's “dev” list.

Search for bugs:

This project uses Bugzilla to track ongoing development and issues.

Create a new bug:

Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!