Bug 553240: ImageLoader save() creates striped images on Linux

A previous patch hardcoded all saved images to 32bit, meaning 4
bytes per pixel. However there was some leftover logic where a
24 bit image without an alpha channel could be loaded and saved
with 3 bytes per pixel. This caused weirdness as the data saving
algorithm was expecting 4 bytes per pixel and therefore some
pixels were not saved correctly.

Tested on Fedora 31, GTK3.24 with the snippet attached, as
well as previous ImageLoader snippets and a child Eclipse. No
AllNonBrowser JUnit tests fails.

Change-Id: I5c7184a2158f07879bd651cca81d8167c36f3d76
Signed-off-by: Eric Williams <ericwill@redhat.com>
3 files changed
tree: b7c7c1e20563cc6fc3db496850644bbb41dea4f5
  1. .gitignore
  5. README.md
  6. bundles/
  7. container/
  8. examples/
  9. features/
  10. local-build/
  11. pom.xml
  12. tests/

Contributing to SWT

Thanks for your interest in this project.

Developer resources:

See the following description for how to contribute a feature or a bug fix to SWT.

Information regarding source code management, builds, coding standards, and more and be found under the following link.

Contributor License Agreement:

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).


Contact the project developers via the project's “dev” list.

Search for bugs:

This project uses Bugzilla to track ongoing development and issues.

Create a new bug:

Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!