| commit | 5a8824f73257a5cf03c6eebf5268bc7f4d30c310 | [log] [tgz] |
|---|---|---|
| author | Lars Vogel <Lars.Vogel@vogella.com> | Tue Jun 08 11:54:54 2021 +0200 |
| committer | Lars Vogel <Lars.Vogel@vogella.com> | Tue Jun 22 06:02:06 2021 -0400 |
| tree | a90b57627347a60a272184e82ba6a82f518f547c | |
| parent | dc887d8ec3e58d68a617566f92d8646be4e7fc63 [diff] |
Use JDT static inner class clean up for
ui.editors
This ticket uses and tests the "Use static inner class" cleanup feature:
- It reviews the feature
- It reduces the memory consumption as it avoids the pointer to the
outer class
Example:
Before:
public class Outer {
public class InnerClass {
int i;
public boolean anotherMethod() {
return true;
}
}
}
After:
public class Outer {
public static class InnerClass {
int i;
public boolean anotherMethod() {
return true;
}
}
}
Change-Id: Id13454b3c8e1e8ca6628d4f15cc6f0aec37cd62a
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181573
Tested-by: Platform Bot <platform-bot@eclipse.org>
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AccessibilityPreferencePage.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AccessibilityPreferencePage.java index deb90ee..2d009b2 100644 --- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AccessibilityPreferencePage.java +++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AccessibilityPreferencePage.java
@@ -59,7 +59,7 @@ public class AccessibilityPreferencePage extends PreferencePage implements IWorkbenchPreferencePage { - private abstract class Initializer { + private abstract static class Initializer { protected final Preference fPreference;
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AnnotationsConfigurationBlock.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AnnotationsConfigurationBlock.java index cd43988..35b7aae 100644 --- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AnnotationsConfigurationBlock.java +++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/AnnotationsConfigurationBlock.java
@@ -109,7 +109,7 @@ } - private final class ItemLabelProvider extends LabelProvider { + private static final class ItemLabelProvider extends LabelProvider { @Override public String getText(Object element) {
diff --git a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java index 2d8255e..ea11e24 100755 --- a/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java +++ b/org.eclipse.ui.editors/src/org/eclipse/ui/internal/editors/text/LinkedModeConfigurationBlock.java
@@ -108,7 +108,7 @@ } } - private final class ItemLabelProvider extends LabelProvider { + private static final class ItemLabelProvider extends LabelProvider { @Override public String getText(Object element) {