)]}'
{
  "commit": "3103ff9603292254334606b3db510f52f1f9f504",
  "tree": "462d586df56d9257ace21bae809a67507474d378",
  "parents": [
    "43b2a6035280803553e0c8ac86dd46b547ea7312"
  ],
  "author": {
    "name": "Andrey Loskutov",
    "email": "loskutov@gmx.de",
    "time": "Thu Jun 28 13:55:43 2018 +0200"
  },
  "committer": {
    "name": "Andrey Loskutov",
    "email": "loskutov@gmx.de",
    "time": "Thu Jun 28 15:01:45 2018 +0200"
  },
  "message": "Bug 531854 - View toolbar misses commands with visibleWhen expression\n\nThe problem is seen when adding a command to a view toolbar, and using a\nvisibleWhen with variable expression. If the command is not visible by\ndefault, but becomes visible later on, the command will not become\nvisible in the toolbar of the view.\n\nThis results from using RowData.exclude on the view menu toolbar. The\nview menu toolbar is not visible if there are no view menu items. This\nis implemented by using RowData.exclude. When a visibleWhen expression\nevaluates true, the composite of the view menu and command toolbars is\nnot updated correctly.\n\nThis change adds a missing pack() call to the parent composite, fixing\nthe problem.\n\nNote, that to avoid issues with broken complex layouts after the toolbar\nis updated (see bug 536409), we change layout() to requestLayout(),\nwhich runs *after* all necessary children updates are performed due\npack().\n\nChange-Id: Ib2225ef8dfbb6a106e4853f8e8b01f716d4620a1\nSigned-off-by: Andrey Loskutov \u003closkutov@gmx.de\u003e\nAlso-by: Simeon Andreev \u003csimeon.danailov.andreev@gmail.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ede09a9750411026ed3ad2dff54991df061e7e21",
      "old_mode": 33188,
      "old_path": "bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java",
      "new_id": "36c0d11f98659038d7be2d76ccf06042bbdac069",
      "new_mode": 33188,
      "new_path": "bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java"
    },
    {
      "type": "modify",
      "old_id": "e9c03cfc3b8b17a3561be6353d0a17f82f9f3aef",
      "old_mode": 33188,
      "old_path": "tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/DialogCheck.java",
      "new_id": "ac536a5c7e5be98c7c11fa8abb429e5b72485e25",
      "new_mode": 33188,
      "new_path": "tests/org.eclipse.ui.tests.harness/src/org/eclipse/ui/tests/harness/util/DialogCheck.java"
    }
  ]
}
