Google Git
Sign in
eclipse / platform / eclipse.platform.ui / 3103ff9603292254334606b3db510f52f1f9f504
commit3103ff9603292254334606b3db510f52f1f9f504[log] [tgz]
authorAndrey Loskutov <loskutov@gmx.de>Thu Jun 28 13:55:43 2018 +0200
committerAndrey Loskutov <loskutov@gmx.de>Thu Jun 28 15:01:45 2018 +0200
tree462d586df56d9257ace21bae809a67507474d378
parent43b2a6035280803553e0c8ac86dd46b547ea7312 [diff]
Bug 531854 - View toolbar misses commands with visibleWhen expression

The problem is seen when adding a command to a view toolbar, and using a
visibleWhen with variable expression. If the command is not visible by
default, but becomes visible later on, the command will not become
visible in the toolbar of the view.

This results from using RowData.exclude on the view menu toolbar. The
view menu toolbar is not visible if there are no view menu items. This
is implemented by using RowData.exclude. When a visibleWhen expression
evaluates true, the composite of the view menu and command toolbars is
not updated correctly.

This change adds a missing pack() call to the parent composite, fixing
the problem.

Note, that to avoid issues with broken complex layouts after the toolbar
is updated (see bug 536409), we change layout() to requestLayout(),
which runs *after* all necessary children updates are performed due
pack().

Change-Id: Ib2225ef8dfbb6a106e4853f8e8b01f716d4620a1
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Also-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2 files changed
tree: 462d586df56d9257ace21bae809a67507474d378
  1. .mvn/
  2. bundles/
  3. examples/
  4. features/
  5. releng/
  6. tests/
  7. .gitignore
  8. CONTRIBUTING.md
  9. pom.xml
  10. README.md
README.md

Contributing to Eclipse Platform UI project

Thanks for your interest in this project.

Project description:

Platform UI provides the basic building blocks for user interfaces built with Eclipse.

Some of these form the Eclipse Rich Client Platform (RCP) and can be used for arbitrary rich client applications, while others are specific to the Eclipse IDE. The Platform UI codebase is built on top of the Eclipse Standard Widget Toolkit (SWT), which is developed as an independent project.

Website: http://www.eclipse.org/platform/ui/

For more information, refer to the Platform UI wiki page.

How to contribute:

Contributions to Platform UI are most welcome. There are many ways to contribute, from entering high quality bug reports, to contributing code or documentation changes. For a complete guide, see the Platform UI - How to contribute wiki page page on the team wiki.

Test dependencies

Several test plug-ins have a dependency to the Mockito and Hamcrest library. Please install them from the Orbit Download page

Currently the following versions are required:

  • org.hamcrest;bundle-version=“1.1.0”,
  • org.mockito;bundle-version=“1.8.4”,

How to build on the command line

You need Maven 3.3.1 installed. After this you can run the build via the following command:

mvn clean verify -Pbuild-individual-bundles

Developer resources:

Information regarding source code management, builds, coding standards, and more.

Contributor License Agreement:

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).

Search for bugs:

This project uses Bugzilla to track ongoing development and issues.

Create a new bug:

Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!

Contact:

Contact the project developers via the project's “dev” list.

License

[Eclipse Public License (EPL) v1.0][4]