Dogfooding - Remove unused private method parameters cleanup for Jface JDT introduced a new clean for removing unused private method parameters, we should use it in our code base to "iron" it out. Change-Id: Ibf71f28da7acff26e2b87cc78640f4f9d3835095
diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeViewer.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeViewer.java index 83934b9..ac304f9 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeViewer.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeViewer.java
@@ -438,7 +438,7 @@ if (index < tree.getItemCount()) { TreeItem item = tree.getItem(index); if (!insidePreservingSelection) { - selection = adjustSelectionForReplace(selectedItems, selection, item, element, getRoot()); + selection = adjustSelectionForReplace(selectedItems, selection, item, element); } // disassociate any different item that represents the // same element under the same parent (the tree) @@ -467,8 +467,7 @@ if (index < parentItem.getItemCount()) { TreeItem item = parentItem.getItem(index); if (!insidePreservingSelection) { - selection = adjustSelectionForReplace(selectedItems, selection, item, element, - parentItem.getData()); + selection = adjustSelectionForReplace(selectedItems, selection, item, element); } // disassociate any different item that represents the // same element under the same parent (the tree) @@ -515,7 +514,7 @@ * @return the adjusted selection */ private TreeSelection adjustSelectionForReplace(Item[] selectedItems, - TreeSelection selection, TreeItem item, Object element, Object parentElement) { + TreeSelection selection, TreeItem item, Object element) { if (item.getData() != null) { // Don't do anything - we are not seeing an instance of bug 185673 return selection;