Bug 528720 - View toolbar painted over view when switching from editor

When an editor tab and a view tab are in the same part stack, switching
from the editor to the view can result in a toolbar painting artifact.
Namely, the view toolbar is painted over the view client area. This can
be observed if the part stack tab area is not long enough to hold the
view toolbar.

This is the case, since the toolbar is drawn within the view area, on
top of the view. The view does not receive a layout update notification,
due to switching from the editor. When switching from another view,
StackRenderer.adjustTopRight will hide the toolbar of the view. This
results in a layout update of the newly opened view. Since the editor
has no toolbar, nothing is hidden and no layout update is queued.

This change improves on the fix for Bug 461573. Instead of triggering a
direct layout update, we request one later on. This later on includes
the adjustment of the toolbar location, resulting in a correctly sized
view. The view toolbar is then no longer painted over the view.

Change-Id: If23c1ed2ab1fe8edc052d647dd89ebed1ed00a0a
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
1 file changed
tree: 9834298978f29ce432a733d5585b9210f703554a
  1. bundles/
  2. examples/
  3. features/
  4. releng/
  5. tests/
  6. .gitignore
  7. CONTRIBUTING.md
  8. pom.xml
  9. README.md
README.md

Contributing to Eclipse Platform UI project

Thanks for your interest in this project.

Project description:

Platform UI provides the basic building blocks for user interfaces built with Eclipse. Some of these form the Eclipse Rich Client Platform (RCP) and can be used for arbitrary rich client applications, while others are specific to the Eclipse IDE. The Platform UI codebase is built on top of the Eclipse Standard Widget Toolkit (SWT), which is developed as an independent project.

Website: http://www.eclipse.org/platform/ui/

For more information, refer to the Platform UI wiki page.

How to contribute:

Contributions to Platform UI are most welcome. There are many ways to contribute, from entering high quality bug reports, to contributing code or documentation changes. For a complete guide, see the Platform UI - How to contribute wiki page page on the team wiki.

How to build on the command line

You need Maven 3.3.1 installed. After this you can run the build via the following command:

mvn clean verify -Pbuild-individual-bundles

Developer resources:

Information regarding source code management, builds, coding standards, and more.

Contributor License Agreement:

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).

Search for bugs:

This project uses Bugzilla to track ongoing development and issues.

Create a new bug:

Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!

Contact:

Contact the project developers via the project's “dev” list.

License

Eclipse Public License (EPL) v1.0