Google Git
Sign in
eclipse / platform / eclipse.platform.ui / refs/tags/I20200320-1800
commitc56299858877ae9c5345598f29355db0fc03fc7b[log] [tgz]
authorKarsten Thoms <karsten.thoms@karakun.com>Wed Nov 09 11:06:41 2016 +0100
committerKarsten Thoms <karsten.thoms@karakun.com>Fri Mar 20 18:08:05 2020 -0400
tree04ae9d42fc5a93deecb507ec412994b732c3331c
parent43c8c32505a7d0d5f43e1951cd6a0c8d0ebd9fa9 [diff]
Bug 492252 - Ensure JobInfo are created with FinishedJobs instance

JobInfo instances were created with a null reference for FinishedJobs in
JobInfoFactory. This change makes the FinishedJobs reference in
ProgressManager non optional, and the JobInfoFactory takes the
ProgressManager's FinishedJobs instance for creation of JobInfos.

This required that FinishedJobs does not require a ProgressManager for
its construction. This was needed to register an
IJobProgressManagerListener to the ProgressManager. Instead of
registering itsels, the ProgressManager now registers the listener. This
resolves the circular dependency between both classes.

On shutdown ProgressManager might already be null. Being resilient for
that.

Change-Id: I7ae3c1f4386f3cf15c23296309599f3e8d5ee19b
Signed-off-by: Karsten Thoms <karsten.thoms@karakun.com>
Also-by: Andrzej Witecki <sodoww@gmail.com>
4 files changed
tree: 04ae9d42fc5a93deecb507ec412994b732c3331c
  1. .mvn/
  2. bundles/
  3. examples/
  4. features/
  5. releng/
  6. tests/
  7. .gitignore
  8. CONTRIBUTING
  9. CONTRIBUTING.md
  10. LICENSE
  11. NOTICE
  12. pom.xml
  13. README.md
README.md

Contributing to Eclipse Platform UI project

Thanks for your interest in this project.

Project description:

Platform UI provides the basic building blocks for user interfaces built with Eclipse.

Some of these form the Eclipse Rich Client Platform (RCP) and can be used for arbitrary rich client applications, while others are specific to the Eclipse IDE. The Platform UI codebase is built on top of the Eclipse Standard Widget Toolkit (SWT), which is developed as an independent project.

Website: http://www.eclipse.org/platform/ui/

For more information, refer to the Platform UI wiki page.

How to contribute:

Contributions to Platform UI are most welcome. There are many ways to contribute, from entering high quality bug reports, to contributing code or documentation changes. For a complete guide, see the Platform UI - How to contribute wiki page page on the team wiki.

Test dependencies

Several test plug-ins have a dependency to the Mockito and Hamcrest libraries. Please install them from the Orbit Download page]3:

Currently the following plug-ins are required:

  • net.bytebuddy.byte-buddy
  • net.bytebuddy.byte-buddy-agent
  • org.hamcrest.core
  • org.mockito
  • org.objenesis

How to build on the command line

You need Maven 3.3.1 installed. After this you can run the build via the following command:

mvn clean verify -Pbuild-individual-bundles

Developer resources:

Information regarding source code management, builds, coding standards, and more.

Contributor License Agreement:

Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).

Search for bugs:

This project uses Bugzilla to track ongoing development and issues.

Create a new bug:

Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!

Contact:

Contact the project developers via the project's “dev” list.

License

Eclipse Public License (EPL) 2.0