Bug 564793 - Fix rendering of square tabs in Launch Configuration dialog
on Light Theme (SWT.BOTTOM). When SWT.BOTTOM with 2 colors for selected
tab fill pattern, we would never setup background and foreground.
Change-Id: I8cd9ae03b7c2c6d7616d1ae417ce5f511a656f9e
Signed-off-by: Mike Marchand <mmarchand@cranksoftware.com>
diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java
index f747447..36c6de0 100644
--- a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java
+++ b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/CTabRendering.java
@@ -524,10 +524,16 @@
if (selectedTabFillColors.length == 1) {
gc.setBackground(selectedTabFillColors[0]);
gc.setForeground(selectedTabFillColors[0]);
- } else if (!onBottom && selectedTabFillColors.length == 2) {
+ } else if (selectedTabFillColors.length == 2) {
// for now we support the 2-colors gradient for selected tab
- backgroundPattern = new Pattern(gc.getDevice(), 0, 0, 0, bounds.height + 1, selectedTabFillColors[0],
- selectedTabFillColors[1]);
+ if (!onBottom) {
+ backgroundPattern = new Pattern(gc.getDevice(), 0, 0, 0, bounds.height + 1, selectedTabFillColors[0],
+ selectedTabFillColors[1]);
+ } else {
+ backgroundPattern = new Pattern(gc.getDevice(), 0, 0, 0, bounds.height + 1, selectedTabFillColors[1],
+ selectedTabFillColors[0]);
+ }
+
gc.setBackgroundPattern(backgroundPattern);
gc.setForeground(selectedTabFillColors[1]);
}
