tree e7f4aefffeae6e2a93ceb5ee4488a4d22f97d0a3
parent 2a2d9433241a46f7fa2df251722f8b2fa54b1d7b
author Remy Suen <remysuen@ca.ibm.com> 1329492521 -0500
committer Remy Suen <remysuen@ca.ibm.com> 1329492521 -0500

Bug 371611 LinkageError in DynamicToolBarContributionItem can cause
workbench startup to fail

If the createControl(Composite) method of a ControlContribution
returns null, we should not bother trying to create a ToolItem
for it. Instead, we should just log an error notifying the user
which class failed to return a non-null control. The current
code of throwing an NPE causes the workbench to not start when
there is such a rogue control contribution. This is unacceptable
as a bad implementation should not prevent the workbench from
starting up.