refs bug 302220 - cleaned up javadocs and warnings
diff --git a/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/GoogleAPIResource.java b/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/GoogleAPIResource.java
index 8685e2e..a031858 100644
--- a/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/GoogleAPIResource.java
+++ b/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/GoogleAPIResource.java
@@ -10,14 +10,13 @@
******************************************************************************/
package org.eclipse.rap.rwt.visualization.google.internal;
-import org.eclipse.rwt.internal.util.HTML;
import org.eclipse.rwt.resources.IResource;
import org.eclipse.rwt.resources.IResourceManager.RegisterOptions;
public class GoogleAPIResource implements IResource {
public String getCharset() {
- return HTML.CHARSET_NAME_ISO_8859_1;
+ return "ISO-8859-1";
}
public ClassLoader getLoader() {
diff --git a/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/GoogleVisualizationResource.java b/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/GoogleVisualizationResource.java
index c59d134..26981bd 100644
--- a/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/GoogleVisualizationResource.java
+++ b/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/GoogleVisualizationResource.java
@@ -10,14 +10,17 @@
******************************************************************************/
package org.eclipse.rap.rwt.visualization.google.internal;
-import org.eclipse.rwt.internal.util.HTML;
import org.eclipse.rwt.resources.IResource;
import org.eclipse.rwt.resources.IResourceManager.RegisterOptions;
+/**
+ * <p>Base type for visualization resources.</p>
+ *
+ */
public abstract class GoogleVisualizationResource implements IResource {
public String getCharset() {
- return HTML.CHARSET_NAME_ISO_8859_1;
+ return "ISO-8859-1";
}
public ClassLoader getLoader() {
diff --git a/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/VisualizationWidgetLCA.java b/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/VisualizationWidgetLCA.java
index 67fe64b..5b9d027 100644
--- a/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/VisualizationWidgetLCA.java
+++ b/bundles/org.eclipse.rap.rwt.visualization.google/src/org/eclipse/rap/rwt/visualization/google/internal/VisualizationWidgetLCA.java
@@ -13,9 +13,7 @@
package org.eclipse.rap.rwt.visualization.google.internal;
import java.io.IOException;
-import java.util.logging.Logger;
-import org.eclipse.rap.rwt.visualization.google.Table;
import org.eclipse.rap.rwt.visualization.google.VisualizationWidget;
import org.eclipse.rwt.lifecycle.AbstractWidgetLCA;
import org.eclipse.rwt.lifecycle.ControlLCAUtil;
@@ -26,13 +24,23 @@
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Widget;
+/**
+ * <p>
+ * Base type for Google Visualizations.
+ * </p>
+ *
+ * <p>
+ * Note that changes to the data or options of a widget obtained via <code>getWidgetData()</code>
+ * and <code>getWidgetOptions()</code> will be propagated to the client side, but the changes
+ * will not be rendered until <code>isDirty()</code> returns true. At that point the client-side widget will
+ * be told to redraw.
+ * </p>
+ */
public abstract class VisualizationWidgetLCA extends AbstractWidgetLCA {
protected static final String REDRAW_FUNC = "redraw";
protected static final String PROP_DATA = "widgetData";
protected static final String PROP_OPTIONS = "widgetOptions";
-// private static final Logger log = Logger.getLogger(VisualizationWidgetLCA.class);
-
public abstract Class getWidgetType();
public void renderInitialization( final Widget widget ) throws IOException {
@@ -73,9 +81,11 @@
}
public void createResetHandlerCalls( String typePoolId ) throws IOException {
+ //preserved empty here for pre RAP 1.3 compatibility
}
public String getTypePoolId( Widget widget ) {
+ //preserved empty here for pre RAP 1.3 compatibility
return null;
}
@@ -95,7 +105,6 @@
visWidget.setSelectedRow( selectedRow );
visWidget.setSelectedColumn( selectedColumn );
visWidget.setSelectedValue( selectedValue );
-// log.debug( "VisualizationWidgetLCA.readData(): widget=" + widget + "; selectedItem=" + selectedItem);
ControlLCAUtil.processSelection( visWidget, null, true );
}
}
