smells 'data clumps' added
diff --git a/org.eclipse.emf.refactor.smells.uml24.metricbased/bin/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsAttributes.class b/org.eclipse.emf.refactor.smells.uml24.metricbased/bin/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsAttributes.class
new file mode 100644
index 0000000..2fa65bc
--- /dev/null
+++ b/org.eclipse.emf.refactor.smells.uml24.metricbased/bin/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsAttributes.class
Binary files differ
diff --git a/org.eclipse.emf.refactor.smells.uml24.metricbased/bin/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsParameters.class b/org.eclipse.emf.refactor.smells.uml24.metricbased/bin/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsParameters.class
new file mode 100644
index 0000000..64f326a
--- /dev/null
+++ b/org.eclipse.emf.refactor.smells.uml24.metricbased/bin/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsParameters.class
Binary files differ
diff --git a/org.eclipse.emf.refactor.smells.uml24.metricbased/plugin.xml b/org.eclipse.emf.refactor.smells.uml24.metricbased/plugin.xml
index fc937c7..23a8243 100644
--- a/org.eclipse.emf.refactor.smells.uml24.metricbased/plugin.xml
+++ b/org.eclipse.emf.refactor.smells.uml24.metricbased/plugin.xml
@@ -10,6 +10,20 @@
modelsmell_metamodel="http://www.eclipse.org/uml2/4.0.0/UML"
modelsmell_name="Abstract Package">
</modelsmell>
+ <modelsmell
+ id="org.eclipse.emf.refactor.smells.uml24.dataclumpsattributes"
+ modelsmell_description="The model contains classes with a specific number of equal attributes."
+ modelsmell_finderclass="org.eclipse.emf.refactor.smells.uml24.metricbased.DataClumpsAttributes"
+ modelsmell_metamodel="http://www.eclipse.org/uml2/4.0.0/UML"
+ modelsmell_name="Data Clumps (Attributes)">
+ </modelsmell>
+ <modelsmell
+ id="org.eclipse.emf.refactor.smells.uml24.dataclumpsparameters"
+ modelsmell_description="The model contains operations with a specific number of equal input parameters."
+ modelsmell_finderclass="org.eclipse.emf.refactor.smells.uml24.metricbased.DataClumpsParameters"
+ modelsmell_metamodel="http://www.eclipse.org/uml2/4.0.0/UML"
+ modelsmell_name="Data Clumps (Parameters)">
+ </modelsmell>
</extension>
</plugin>
diff --git a/org.eclipse.emf.refactor.smells.uml24.metricbased/src/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsAttributes.java b/org.eclipse.emf.refactor.smells.uml24.metricbased/src/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsAttributes.java
new file mode 100644
index 0000000..677a0e9
--- /dev/null
+++ b/org.eclipse.emf.refactor.smells.uml24.metricbased/src/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsAttributes.java
@@ -0,0 +1,52 @@
+package org.eclipse.emf.refactor.smells.uml24.metricbased;
+
+import java.util.LinkedList;
+import java.util.List;
+
+import org.eclipse.emf.ecore.EObject;
+import org.eclipse.emf.refactor.metrics.core.Metric;
+import org.eclipse.emf.refactor.metrics.interfaces.IMetricCalculator;
+import org.eclipse.emf.refactor.smells.core.MetricBasedModelSmellFinderClass;
+
+public class DataClumpsAttributes extends MetricBasedModelSmellFinderClass {
+
+ private String metricId = "org.eclipse.emf.refactor.metrics.uml24.neatc";
+ private Metric localMetric = Metric.getMetricInstanceFromId(metricId);
+
+ @Override
+ public LinkedList<LinkedList<EObject>> findSmell(EObject root) {
+ LinkedList<EObject> rootList = new LinkedList<EObject>();
+ rootList.add(root);
+ IMetricCalculator localCalculateClass = localMetric.getCalculateClass();
+ double globalLimit = this.getLimit();
+ return findSmellyObjectGroups(root, globalLimit, localCalculateClass);
+ }
+
+ private LinkedList<LinkedList<EObject>> findSmellyObjectGroups(EObject root, double globalLimit,
+ IMetricCalculator localCalculateClass) {
+ String context = localMetric.getContext();
+ LinkedList<LinkedList<EObject>> smellyEObjects = new LinkedList<LinkedList<EObject>>();
+ List<EObject> containedEObjects = root.eContents();
+ for(EObject object : containedEObjects){
+ String objectType = object.eClass().getInstanceClass().getSimpleName();
+ if(objectType.equals(context)){
+ LinkedList<EObject> rootList = new LinkedList<EObject>();
+ rootList.add(object);
+ localCalculateClass.setContext(rootList);
+ double localValue = localCalculateClass.calculate();
+ if(limitReached(localValue, globalLimit)) {
+ LinkedList<EObject> currentObjects = new LinkedList<EObject>();
+ currentObjects.add(object);
+ smellyEObjects.add((currentObjects));
+ }
+ } else {
+ smellyEObjects.addAll(findSmellyObjectGroups(object, globalLimit, localCalculateClass));
+ }
+ }
+ return smellyEObjects;
+ }
+
+ private boolean limitReached(double localValue, double globalLimit) {
+ return (localValue > globalLimit);
+ }
+}
diff --git a/org.eclipse.emf.refactor.smells.uml24.metricbased/src/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsParameters.java b/org.eclipse.emf.refactor.smells.uml24.metricbased/src/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsParameters.java
new file mode 100644
index 0000000..f5584ba
--- /dev/null
+++ b/org.eclipse.emf.refactor.smells.uml24.metricbased/src/org/eclipse/emf/refactor/smells/uml24/metricbased/DataClumpsParameters.java
@@ -0,0 +1,52 @@
+package org.eclipse.emf.refactor.smells.uml24.metricbased;
+
+import java.util.LinkedList;
+import java.util.List;
+
+import org.eclipse.emf.ecore.EObject;
+import org.eclipse.emf.refactor.metrics.core.Metric;
+import org.eclipse.emf.refactor.metrics.interfaces.IMetricCalculator;
+import org.eclipse.emf.refactor.smells.core.MetricBasedModelSmellFinderClass;
+
+public class DataClumpsParameters extends MetricBasedModelSmellFinderClass {
+
+ private String metricId = "org.eclipse.emf.refactor.metrics.uml24.neipo";
+ private Metric localMetric = Metric.getMetricInstanceFromId(metricId);
+
+ @Override
+ public LinkedList<LinkedList<EObject>> findSmell(EObject root) {
+ LinkedList<EObject> rootList = new LinkedList<EObject>();
+ rootList.add(root);
+ IMetricCalculator localCalculateClass = localMetric.getCalculateClass();
+ double globalLimit = this.getLimit();
+ return findSmellyObjectGroups(root, globalLimit, localCalculateClass);
+ }
+
+ private LinkedList<LinkedList<EObject>> findSmellyObjectGroups(EObject root, double globalLimit,
+ IMetricCalculator localCalculateClass) {
+ String context = localMetric.getContext();
+ LinkedList<LinkedList<EObject>> smellyEObjects = new LinkedList<LinkedList<EObject>>();
+ List<EObject> containedEObjects = root.eContents();
+ for(EObject object : containedEObjects){
+ String objectType = object.eClass().getInstanceClass().getSimpleName();
+ if(objectType.equals(context)){
+ LinkedList<EObject> rootList = new LinkedList<EObject>();
+ rootList.add(object);
+ localCalculateClass.setContext(rootList);
+ double localValue = localCalculateClass.calculate();
+ if(limitReached(localValue, globalLimit)) {
+ LinkedList<EObject> currentObjects = new LinkedList<EObject>();
+ currentObjects.add(object);
+ smellyEObjects.add((currentObjects));
+ }
+ } else {
+ smellyEObjects.addAll(findSmellyObjectGroups(object, globalLimit, localCalculateClass));
+ }
+ }
+ return smellyEObjects;
+ }
+
+ private boolean limitReached(double localValue, double globalLimit) {
+ return (localValue > globalLimit);
+ }
+}
