[refactoring] Gerrit Service
Adapt package names to conform to usual convention for
Skalli core services:
"org.eclipse.skalli.services.gerrit" is now the name for
the only exported package that constitutes the API of the
Gerrit service; it contains the interfaces GerritService
and GerritClient, all exceptions and helper classes,
and the configuration classes GerritServersConfig und
GerritServerConfig.
"org.eclipse.skalli.core.gerrit" contains now the service
implementation and the configuration adapters.
Rename GerritServiceImpl to GerritComponent
Service implementations should have the name suffix
"Component" instead of "Impl". Changed also the service
name to "org.eclipse.skalli.core.component.gerrit"
to conform with the convention in the core bundle.
Renamed GerritClientImpl to GerritClientSSH
As preparation for the implementation of a REST-based
Gerrit client the old SSH-based client has been moved to
the package "org.eclipse.skalli.core.gerrit.ssh" and has
been renamed to "GerritClientSSH".
The service will now return an SSH client only in case
that the protocol in the corresponding server configuration
equals "ssh".
Remove some SSH-specifics
GerritClient provided a constant for the default SSH port.
This has been removed, and the handling of the default port
is now in SSHGerritClient were it belongs. All other places
where default ports were set or checked have been adapted.
Furthermore, some Javadoc comments haven been adapted.
The GSQL legacy has been moved to SSHGerritClient and marked
as deprecated. Support for Gerrit servers before 2.6 will be
removed in a subsequent patch.
Change-Id: Icfaa9e24b55a3112b1bee20499b8b0ec1aeebc6e
Signed-off-by: Michael Ochmann <michael.ochmann@sap.com>
30 files changed
