Correct use of String.toLowerCase/.toUpperCase
diff --git a/r/org.eclipse.statet.r.core-tests/src/org/eclipse/statet/r/core/data/RValueFormatter03numTest.java b/r/org.eclipse.statet.r.core-tests/src/org/eclipse/statet/r/core/data/RValueFormatter03numTest.java
index f3754b2..f242036 100644
--- a/r/org.eclipse.statet.r.core-tests/src/org/eclipse/statet/r/core/data/RValueFormatter03numTest.java
+++ b/r/org.eclipse.statet.r.core-tests/src/org/eclipse/statet/r/core/data/RValueFormatter03numTest.java
@@ -16,6 +16,8 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
+import java.util.Locale;
+
import org.junit.jupiter.api.Test;
@@ -114,7 +116,7 @@
this.formatter.clear();
this.formatter.appendNum(values[i]);
- final String expected= Double.toString(values[i]).toLowerCase();
+ final String expected= Double.toString(values[i]).toLowerCase(Locale.ROOT);
assertEquals(expected, this.formatter.getString(), () -> String.format("formatted strings differ for sample [%1$s]", index0));
}
}
diff --git a/r/org.eclipse.statet.r.core-tests/src/org/eclipse/statet/r/core/data/RValueFormatter05chrTest.java b/r/org.eclipse.statet.r.core-tests/src/org/eclipse/statet/r/core/data/RValueFormatter05chrTest.java
index 8a22606..6dc9c1b 100644
--- a/r/org.eclipse.statet.r.core-tests/src/org/eclipse/statet/r/core/data/RValueFormatter05chrTest.java
+++ b/r/org.eclipse.statet.r.core-tests/src/org/eclipse/statet/r/core/data/RValueFormatter05chrTest.java
@@ -16,6 +16,8 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
+import java.util.Locale;
+
import org.junit.jupiter.api.Test;
@@ -129,7 +131,7 @@
for (char c= 0x80; c <= 0xFF; c++) {
if ((c >= 0x80 && c <= 0x9F) || c == 0xAD) {
rawBuilder.append(c);
- expectedBuilder.append("\\u{").append(Integer.toHexString(c).toUpperCase()).append("}");
+ expectedBuilder.append("\\u{").append(Integer.toHexString(c).toUpperCase(Locale.ROOT)).append("}");
}
else {
rawBuilder.append(c);
diff --git a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/pkgmanager/RPkgManagerImpl.java b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/pkgmanager/RPkgManagerImpl.java
index 8cf120e..3150c8c 100644
--- a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/pkgmanager/RPkgManagerImpl.java
+++ b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/pkgmanager/RPkgManagerImpl.java
@@ -1097,7 +1097,7 @@
}
private RRepoMirror getRegionMirror(final List<RRepoMirror> mirrors) {
- final String countryCode= Locale.getDefault().getCountry().toLowerCase();
+ final String countryCode= Locale.getDefault().getCountry().toLowerCase(Locale.ROOT);
RRepoMirror http= null;
for (final RRepoMirror repo : mirrors) {
if (countryCode.equals(repo.getCountryCode())) {
@@ -1295,7 +1295,7 @@
final RPkg pkg= RPkgUtils.checkPkgFileName(store.getName());
final RPkgType type= RPkgUtils.checkPkgType(store.getName(), this.rPlatform);
this.cache.add(pkg.getName(), type, store, monitor);
- return new RPkgData(pkg.getName(), RNumVersion.NONE, RRepo.WS_CACHE_PREFIX + type.name().toLowerCase());
+ return new RPkgData(pkg.getName(), RNumVersion.NONE, RRepo.WS_CACHE_PREFIX + type.name().toLowerCase(Locale.ROOT));
}
catch (final StatusException e) {
throw StatusUtils.convert(e);
diff --git a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/pkgmanager/Util.java b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/pkgmanager/Util.java
index a817c09..5180639 100644
--- a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/pkgmanager/Util.java
+++ b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/pkgmanager/Util.java
@@ -15,6 +15,7 @@
package org.eclipse.statet.internal.r.core.pkgmanager;
import java.util.List;
+import java.util.Locale;
import org.eclipse.statet.r.core.pkgmanager.RPkgUtils;
import org.eclipse.statet.r.core.pkgmanager.RRepo;
@@ -75,7 +76,7 @@
return RPkgType.valueOf(name);
}
catch (final IllegalArgumentException e) {
- return RPkgType.valueOf(name.toUpperCase());
+ return RPkgType.valueOf(name.toUpperCase(Locale.ROOT));
}
}
diff --git a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/renv/REnvConfigurationImpl.java b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/renv/REnvConfigurationImpl.java
index cca9b8b..f3a981a 100644
--- a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/renv/REnvConfigurationImpl.java
+++ b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/internal/r/core/renv/REnvConfigurationImpl.java
@@ -26,6 +26,7 @@
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.List;
+import java.util.Locale;
import java.util.Map;
import java.util.Properties;
import java.util.Set;
@@ -823,7 +824,7 @@
@Override
public List<String> getExecCommand(String arg1, final Set<Exec> execTypes) throws CoreException {
- final String test= (arg1 != null) ? arg1.trim().toUpperCase() : ""; //$NON-NLS-1$
+ final String test= (arg1 != null) ? arg1.trim().toUpperCase(Locale.ROOT) : ""; //$NON-NLS-1$
Exec type= Exec.COMMON;
if (test.equals("CMD")) { //$NON-NLS-1$
if (execTypes.contains(Exec.CMD)) {
diff --git a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/r/core/RSymbolComparator.java b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/r/core/RSymbolComparator.java
index a8e9307..9fda553 100644
--- a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/r/core/RSymbolComparator.java
+++ b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/r/core/RSymbolComparator.java
@@ -37,7 +37,7 @@
public PrefixPattern(final String namePrefix) {
- this.prefix= namePrefix.toLowerCase().toCharArray();
+ this.prefix= namePrefix.toLowerCase(Locale.ROOT).toCharArray();
}
diff --git a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/r/core/pkgmanager/RRepoMirror.java b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/r/core/pkgmanager/RRepoMirror.java
index 76c779f..f2a5a06 100644
--- a/r/org.eclipse.statet.r.core/src/org/eclipse/statet/r/core/pkgmanager/RRepoMirror.java
+++ b/r/org.eclipse.statet.r.core/src/org/eclipse/statet/r/core/pkgmanager/RRepoMirror.java
@@ -14,6 +14,8 @@
package org.eclipse.statet.r.core.pkgmanager;
+import java.util.Locale;
+
public class RRepoMirror extends RRepo {
@@ -24,7 +26,7 @@
public RRepoMirror(final String id, final String name, final String url, final String countryCode) {
super(id, name, url, null);
- this.countryCode= (countryCode != null) ? countryCode.toLowerCase() : null;
+ this.countryCode= (countryCode != null) ? countryCode.toLowerCase(Locale.ROOT) : null;
}
diff --git a/r/org.eclipse.statet.r.ui/src/org/eclipse/statet/internal/r/ui/graphics/StatetRGraphicCopyToDevWizard.java b/r/org.eclipse.statet.r.ui/src/org/eclipse/statet/internal/r/ui/graphics/StatetRGraphicCopyToDevWizard.java
index fc314cb..2db9e26 100644
--- a/r/org.eclipse.statet.r.ui/src/org/eclipse/statet/internal/r/ui/graphics/StatetRGraphicCopyToDevWizard.java
+++ b/r/org.eclipse.statet.r.ui/src/org/eclipse/statet/internal/r/ui/graphics/StatetRGraphicCopyToDevWizard.java
@@ -14,6 +14,8 @@
package org.eclipse.statet.internal.r.ui.graphics;
+import java.util.Locale;
+
import org.eclipse.core.databinding.DataBindingContext;
import org.eclipse.core.databinding.UpdateValueStrategy;
import org.eclipse.core.databinding.observable.Realm;
@@ -92,7 +94,7 @@
public ConfigPage() {
super("Config"); //$NON-NLS-1$
- this.settingType= StatetRGraphicCopyToDevWizard.this.devAbbr.toLowerCase();
+ this.settingType= StatetRGraphicCopyToDevWizard.this.devAbbr.toLowerCase(Locale.ROOT);
setTitle(NLS.bind("Save Graphic as {0} using R", StatetRGraphicCopyToDevWizard.this.devAbbr.toUpperCase()));
setDescription("Select the file to save the graphic to.");
