commit d2061be518f1117071e39c6e852bdd5e262f9c00
author Frederic Leger <frederic.leger@windriver.com> Wed Oct 22 08:32:47 2014 +0200
committer Frederic Leger <frederic.leger@windriver.com> Wed Oct 22 08:32:47 2014 +0200
tree 6ba2f3485d3362dfb54cc4caf83f8526359cbc39
parent a523c0b428f08e9c61ca788af97ec38bc677e313

Disassembler - block disassembler endless loop.

Ifever the disassembler returns a bad instruction size of zero, the block
disassembly could loop forever.

agent/tcf/services/disassembly.c

diff --git a/agent/tcf/services/disassembly.c b/agent/tcf/services/disassembly.c
index fad84be..0295b4d 100644
--- a/agent/tcf/services/disassembly.c
+++ b/agent/tcf/services/disassembly.c
@@ -213,7 +213,8 @@
             disassembler_ok = 1;
         }
         if (disassembler) dr = disassembler(mem_buf + (size_t)offs, addr, size, &param);
-        if (dr == NULL) {
+	/* To avoid looping forever, better check for instrcution size */
+        if ((dr == NULL) || (dr != NULL && dr->size == 0)){
             static char buf[32];
             static DisassemblyResult dd;
             memset(&dd, 0, sizeof(dd));