Fixed bug 465630: [JUnit] "Next/Previous Failed Test" buttons enabled on
"Show Skipped Tests Only"
Change-Id: I44045a229d8ebab32892d6ac95dc3a68657030c7
diff --git a/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/TestRunnerViewPart.java b/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/TestRunnerViewPart.java
index cec4c51..ba34d59 100644
--- a/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/TestRunnerViewPart.java
+++ b/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/TestRunnerViewPart.java
@@ -1268,13 +1268,17 @@
else {
updateViewIcon();
}
- boolean hasErrorsOrFailures= hasErrorsOrFailures();
- fNextAction.setEnabled(hasErrorsOrFailures);
- fPreviousAction.setEnabled(hasErrorsOrFailures);
+ updateNextPreviousActions();
fTestViewer.processChangesInUI();
}
+ private void updateNextPreviousActions() {
+ boolean hasErrorsOrFailures= !fIgnoredOnlyFilterAction.isChecked() && hasErrorsOrFailures();
+ fNextAction.setEnabled(hasErrorsOrFailures);
+ fPreviousAction.setEnabled(hasErrorsOrFailures);
+ }
+
/**
* Stops the currently running test and shuts down the RemoteTestRunner
*/
@@ -2222,6 +2226,7 @@
fFailuresOnlyFilterAction.setChecked(failuresOnly);
fIgnoredOnlyFilterAction.setChecked(ignoredOnly);
fTestViewer.setShowFailuresOrIgnoredOnly(failuresOnly, ignoredOnly, layoutMode);
+ updateNextPreviousActions();
}
private void setShowExecutionTime(boolean showTime) {
