remove unused maven plugins; move USED ones out of pluginManagement and into plugins, so they're actually active

Signed-off-by: nickboldt <nboldt@redhat.com>
diff --git a/pom.xml b/pom.xml
index 8c8d604..946288d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -12,6 +12,7 @@
       <tycho-version>1.0.0</tycho-version>
       <tycho-extras-version>1.0.0</tycho-extras-version>
       <maven-resources-version>2.6</maven-resources-version>
+
       <!-- TODO: switch to 4.8 after June 27, 2018 -->
       <sdk-version>4.8milestones</sdk-version>
 
@@ -148,179 +149,134 @@
               </execution>
             </executions>
           </plugin> 
-        </plugins>
-        <pluginManagement>
-            <plugins>
-                <plugin>
-                    <groupId>org.eclipse.tycho</groupId>
-                    <artifactId>tycho-maven-plugin</artifactId>
-                    <version>${tycho-version}</version>
-                    <extensions>true</extensions>
-                </plugin>
-                <plugin>
-                    <groupId>org.eclipse.tycho</groupId>
-                    <artifactId>target-platform-configuration</artifactId>
-                    <version>${tycho-version}</version>
-                    <configuration>
-                        <environments>
-                            <environment>
-                                <os>linux</os>
-                                <ws>gtk</ws>
-                                <arch>x86</arch>
-                            </environment>
-                            <environment>
-                                <os>linux</os>
-                                <ws>gtk</ws>
-                                <arch>x86_64</arch>
-                            </environment>
-                            <environment>
-                                <os>win32</os>
-                                <ws>win32</ws>
-                                <arch>x86</arch>
-                            </environment>
-                        </environments>
-                        <resolver>p2</resolver>
-                        <ignoreTychoRepositories>true</ignoreTychoRepositories>
-                        <includePackedArtifacts>true</includePackedArtifacts>
-                        <pomDependencies>consider</pomDependencies>
-                        <filters>
-                            <filter>
-                                <type>eclipse-plugin</type>
-                                <id>org.apache.commons.net</id>
-                                <restrictTo>
-                                    <versionRange>[3.2,3.3)</versionRange>
-                                </restrictTo>
-                            </filter>
-                            <filter>
-                                <type>eclipse-plugin</type>
-                                <id>org.apache.commons.net.source</id>
-                                <restrictTo>
-                                    <versionRange>[3.2,3.3)</versionRange>
-                                </restrictTo>
-                            </filter>
-                        </filters>
-                    </configuration>
-                </plugin>
-                <plugin>
-                    <groupId>org.eclipse.tycho</groupId>
-                    <artifactId>tycho-compiler-plugin</artifactId>
-                    <version>${tycho-version}</version>
-                    <configuration>
-                        <compilerArgument>-warn:+discouraged,forbidden</compilerArgument>
-                        <!-- ignore project settings which appear in Eclipse but are ignored by Tycho <= 0.26, like API access restrictions -->
-                        <useProjectSettings>false</useProjectSettings>
-                        <encoding>UTF-8</encoding>
-                    </configuration>
-                </plugin>
-                <plugin>
-                    <groupId>org.eclipse.tycho</groupId>
-                    <artifactId>tycho-source-plugin</artifactId>
-                    <version>${tycho-version}</version>
-                    <configuration>
-                        <encoding>UTF-8</encoding>
-                    </configuration>
-                    <executions>
-                        <execution>
-                            <id>plugin-source</id>
-                            <goals>
-                                <goal>plugin-source</goal>
-                            </goals>
-                        </execution>
-                    </executions>
-                </plugin>
-                <plugin>
-                  <groupId>org.eclipse.tycho.extras</groupId>
-                  <artifactId>tycho-source-feature-plugin</artifactId>
-                  <version>${tycho-extras-version}</version>
-                  <executions>
-                    <execution>
-                      <id>source-feature</id>
-                      <phase>package</phase>
+          <plugin>
+              <groupId>org.eclipse.tycho</groupId>
+              <artifactId>target-platform-configuration</artifactId>
+              <version>${tycho-version}</version>
+              <configuration>
+                  <environments>
+                      <environment>
+                          <os>linux</os>
+                          <ws>gtk</ws>
+                          <arch>x86</arch>
+                      </environment>
+                      <environment>
+                          <os>linux</os>
+                          <ws>gtk</ws>
+                          <arch>x86_64</arch>
+                      </environment>
+                      <environment>
+                          <os>win32</os>
+                          <ws>win32</ws>
+                          <arch>x86</arch>
+                      </environment>
+                  </environments>
+                  <resolver>p2</resolver>
+                  <ignoreTychoRepositories>true</ignoreTychoRepositories>
+                  <includePackedArtifacts>true</includePackedArtifacts>
+                  <pomDependencies>consider</pomDependencies>
+                  <filters>
+                      <filter>
+                          <type>eclipse-plugin</type>
+                          <id>org.apache.commons.net</id>
+                          <restrictTo>
+                              <versionRange>[3.2,3.3)</versionRange>
+                          </restrictTo>
+                      </filter>
+                      <filter>
+                          <type>eclipse-plugin</type>
+                          <id>org.apache.commons.net.source</id>
+                          <restrictTo>
+                              <versionRange>[3.2,3.3)</versionRange>
+                          </restrictTo>
+                      </filter>
+                  </filters>
+              </configuration>
+          </plugin>
+          <plugin>
+              <groupId>org.eclipse.tycho</groupId>
+              <artifactId>tycho-compiler-plugin</artifactId>
+              <version>${tycho-version}</version>
+              <configuration>
+                  <compilerArgument>-warn:+discouraged,forbidden</compilerArgument>
+                  <!-- ignore project settings which appear in Eclipse but are ignored by Tycho <= 0.26, like API access restrictions -->
+                  <useProjectSettings>false</useProjectSettings>
+                  <encoding>UTF-8</encoding>
+              </configuration>
+          </plugin>
+          <plugin>
+              <groupId>org.eclipse.tycho</groupId>
+              <artifactId>tycho-source-plugin</artifactId>
+              <version>${tycho-version}</version>
+              <configuration>
+                  <encoding>UTF-8</encoding>
+              </configuration>
+              <executions>
+                  <execution>
+                      <id>plugin-source</id>
                       <goals>
-                        <goal>source-feature</goal>
+                          <goal>plugin-source</goal>
                       </goals>
-                    </execution>
-                  </executions>
-                </plugin>
-                <plugin>
-                    <groupId>org.eclipse.tycho</groupId>
-                    <artifactId>tycho-packaging-plugin</artifactId>
-                    <version>${tycho-version}</version>
-                    <dependencies>
-                        <dependency>
-                            <groupId>org.eclipse.tycho.extras</groupId>
-                            <artifactId>tycho-buildtimestamp-jgit</artifactId>
-                            <version>${tycho-version}</version>
-                        </dependency>
-                        <dependency>
-                            <groupId>org.eclipse.tycho.extras</groupId>
-                            <artifactId>tycho-sourceref-jgit</artifactId>
-                            <version>${tycho-extras-version}</version>
-                        </dependency>
-                    </dependencies>
-                    <configuration>
-                        <strictBinIncludes>false</strictBinIncludes>
-                        <timestampProvider>jgit</timestampProvider>
-                        <jgit.ignore>pom.xml</jgit.ignore>
-                        <jgit.dirtyWorkingTree>ignore</jgit.dirtyWorkingTree>
-                        <sourceReferences>
-                            <generate>true</generate>
-                        </sourceReferences>
-                    </configuration>
-                </plugin>
-                <plugin>
-                    <groupId>org.eclipse.tycho</groupId>
-                    <artifactId>tycho-p2-repository-plugin</artifactId>
-                    <version>${tycho-version}</version>
-                    <configuration>
-                        <finalName>${project.artifactId}</finalName>
-                    </configuration>
-                </plugin>
-                <plugin>
-                    <groupId>org.apache.maven.plugins</groupId>
-                    <artifactId>maven-resources-plugin</artifactId>
-                    <version>${maven-resources-version}</version>
-                    <configuration>
-                        <encoding>UTF-8</encoding>
-                    </configuration>
-                </plugin>
-                <plugin>
-                    <groupId>org.apache.maven.plugins</groupId>
-                    <artifactId>maven-antrun-plugin</artifactId>
-                    <version>${maven-antrun-version}</version>
-                </plugin>
-                <plugin>
-                    <groupId>org.codehaus.gmaven</groupId>
-                    <artifactId>gmaven-plugin</artifactId>
-                    <version>${gmaven-version}</version>
-                </plugin>
-                <plugin>
-                    <groupId>org.codehaus.mojo</groupId>
-                    <artifactId>findbugs-maven-plugin</artifactId>
-                    <version>${findbugs-version}</version>
-                    <configuration>
-                        <encoding>UTF-8</encoding>
-                        <effort>Max</effort>
-                        <threshold>Low</threshold>
-                        <xmlOutput>true</xmlOutput>
-                        <failOnError>false</failOnError>
-                        <excludeFilterFile>${adminDir}/findbugs-exclude.xml</excludeFilterFile>
-                    </configuration>
-                    <executions>
-                        <execution>
-                            <goals>
-                                <goal>check</goal>
-                            </goals>
-                        </execution>
-                    </executions>
-                </plugin>
-                <plugin>        
-                    <groupId>org.jacoco</groupId>
-                    <artifactId>jacoco-maven-plugin</artifactId>
-                    <version>${jacoco-version}</version>
-                </plugin>
-            </plugins>
-        </pluginManagement>
+                  </execution>
+              </executions>
+          </plugin>
+          <plugin>
+            <groupId>org.eclipse.tycho.extras</groupId>
+            <artifactId>tycho-source-feature-plugin</artifactId>
+            <version>${tycho-extras-version}</version>
+            <executions>
+              <execution>
+                <id>source-feature</id>
+                <phase>package</phase>
+                <goals>
+                  <goal>source-feature</goal>
+                </goals>
+              </execution>
+            </executions>
+          </plugin>
+          <plugin>
+              <groupId>org.eclipse.tycho</groupId>
+              <artifactId>tycho-packaging-plugin</artifactId>
+              <version>${tycho-version}</version>
+              <dependencies>
+                  <dependency>
+                      <groupId>org.eclipse.tycho.extras</groupId>
+                      <artifactId>tycho-buildtimestamp-jgit</artifactId>
+                      <version>${tycho-version}</version>
+                  </dependency>
+                  <dependency>
+                      <groupId>org.eclipse.tycho.extras</groupId>
+                      <artifactId>tycho-sourceref-jgit</artifactId>
+                      <version>${tycho-extras-version}</version>
+                  </dependency>
+              </dependencies>
+              <configuration>
+                  <strictBinIncludes>false</strictBinIncludes>
+                  <timestampProvider>jgit</timestampProvider>
+                  <jgit.ignore>pom.xml</jgit.ignore>
+                  <jgit.dirtyWorkingTree>ignore</jgit.dirtyWorkingTree>
+                  <sourceReferences>
+                      <generate>true</generate>
+                  </sourceReferences>
+              </configuration>
+          </plugin>
+          <plugin>
+              <groupId>org.eclipse.tycho</groupId>
+              <artifactId>tycho-p2-repository-plugin</artifactId>
+              <version>${tycho-version}</version>
+              <configuration>
+                  <finalName>${project.artifactId}</finalName>
+              </configuration>
+          </plugin>
+          <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-resources-plugin</artifactId>
+              <version>${maven-resources-version}</version>
+              <configuration>
+                  <encoding>UTF-8</encoding>
+              </configuration>
+          </plugin>
+      </plugins>
     </build>
 
     <profiles>