Bug 339982 - MenuContribution with visibleWhen Expression still visible when false
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java index bc31121..2fe7759 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuHelper.java
@@ -350,6 +350,7 @@ text = text.substring(0, idx) + '&' + text.substring(idx); } } + element.setVisibleWhen(getVisibleWhen(menuAddition)); element.setIconURI(MenuHelper .getIconUrl(menuAddition, IWorkbenchRegistryConstants.ATT_ICON)); element.setLabel(Util.safeString(text));