Bug 510634 - Sensless code to check REMOVE_ON_HIDE in BaseStackRenderer#handleChildrenRemove
diff --git a/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseStackRenderer.java b/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseStackRenderer.java
index 82c1083..12a2ad8 100755
--- a/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseStackRenderer.java
+++ b/bundles/runtime/org.eclipse.fx.ui.workbench.renderers.base/src/org/eclipse/fx/ui/workbench/renderers/base/BaseStackRenderer.java
@@ -380,18 +380,19 @@
// build the stack item list out of the model
List<@NonNull WStackItem<I, IC>> items = transmuteList(parentWidget, list);
parentWidget.removeItems(items);
- ArrayList<MStackElement> removeOnHideList = new ArrayList<MStackElement>();
+// ArrayList<MStackElement> removeOnHideList = new ArrayList<MStackElement>();
Boolean b = (Boolean) this.application.getContext().get("__efx_engine_shutdown"); //$NON-NLS-1$
if( b == null || ! b.booleanValue() ) {
for (MStackElement element : list) {
- if (element.getTags().contains(EPartService.REMOVE_ON_HIDE_TAG)) {
- removeOnHideList.add(element);
- }
+// Unnecessary code
+// if (element.getTags().contains(EPartService.REMOVE_ON_HIDE_TAG)) {
+// removeOnHideList.add(element);
+// }
if( ! element.getTransientData().containsKey(MAP_MOVE) ) {
element.getTransientData().remove(MAP_ITEM_KEY);
}
}
- parent.getChildren().removeAll(removeOnHideList);
+// parent.getChildren().removeAll(removeOnHideList);
}
checkSelectedElement(parent);
