| commit | 8d8b606517d94ad814b477e32128f788820c5ac8 | [log] [tgz] |
|---|---|---|
| author | Pascal Rapicault <pascal@rapicorp.com> | Mon Nov 21 16:23:04 2016 -0500 |
| committer | Pascal Rapicault <pascal@rapicorp.com> | Mon Nov 21 16:23:04 2016 -0500 |
| tree | f3b959c97def0c87da3af4a4881cf4bd39613619 | |
| parent | 9fd66c20d45a5ffe44057d03f362af6458f10bad [diff] |
Bug 507710 - Hover on stars is not very useful Update the message to be a bit more useful Change-Id: Ieab54d1b031cb2a0a848449158a753c8f8c5b5ec Signed-off-by: Pascal Rapicault <pascal@rapicorp.com>
diff --git a/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/Messages.java b/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/Messages.java index c6f6bcb..8144458 100644 --- a/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/Messages.java +++ b/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/Messages.java
@@ -41,6 +41,10 @@ public static String ReviewTableDefinition_verify; + public static String Starred; + + public static String Not_Starred; + static { // initialize resource bundle NLS.initializeMessages(BUNDLE_NAME, Messages.class);
diff --git a/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/ReviewTableLabelProvider.java b/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/ReviewTableLabelProvider.java index 4bab546..5d0cc79 100644 --- a/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/ReviewTableLabelProvider.java +++ b/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/ReviewTableLabelProvider.java
@@ -196,7 +196,11 @@ switch (aIndex) { case 0: Boolean starred = reviewSummary.isStarred(); - return starred.toString(); // Needed for the sorter + if (starred) { + return Messages.Starred; + } else { + return Messages.Not_Starred; + } case 1: return Integer.toString(reviewSummary.get_number()); case 2:
diff --git a/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/messages.properties b/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/messages.properties index f7a7c54..94ae5d8 100644 --- a/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/messages.properties +++ b/org.eclipse.egerrit.dashboard.ui/src/org/eclipse/egerrit/internal/dashboard/ui/model/messages.properties
@@ -19,3 +19,5 @@ ReviewTableDefinition_status=Status ReviewTableDefinition_updated=Updated ReviewTableDefinition_verify=V +Starred=Starred review +Not_Starred=Not starred review \ No newline at end of file