| commit | a30d90d6e9fa3d421d0cf73cbac5393ece73be4a | [log] [tgz] |
|---|---|---|
| author | Remy Suen <rsuen> | Tue May 10 18:46:06 2011 +0000 |
| committer | Remy Suen <rsuen> | Tue May 10 18:46:06 2011 +0000 |
| tree | ec26be069fae9d412845887f9a2396bed901e464 | |
| parent | 170d4de96b2e0854eccd2de4b7d476f24e78f3af [diff] |
Bug 340771 View is empty when first opened
diff --git a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/PartServiceImpl.java b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/PartServiceImpl.java index 2f66337..1d66f30 100644 --- a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/PartServiceImpl.java +++ b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/PartServiceImpl.java
@@ -83,9 +83,17 @@ && getParts().contains(selectedPart)) { MPlaceholder placeholder = selectedPart.getCurSharedRef(); // ask the renderer to create this part - engine.createGui(placeholder == null ? selectedPart : placeholder); - firePartVisible(selectedPart); - firePartBroughtToTop(selectedPart); + if (placeholder == null) { + if (selectedPart.getParent().getRenderer() != null) { + engine.createGui(selectedPart); + firePartVisible(selectedPart); + firePartBroughtToTop(selectedPart); + } + } else if (placeholder.getParent().getRenderer() != null) { + engine.createGui(placeholder); + firePartVisible(selectedPart); + firePartBroughtToTop(selectedPart); + } } } }
diff --git a/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/HeadlessContextPresentationEngine.java b/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/HeadlessContextPresentationEngine.java index a0228bc..0d43138 100644 --- a/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/HeadlessContextPresentationEngine.java +++ b/tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/HeadlessContextPresentationEngine.java
@@ -304,6 +304,7 @@ placeholders.add(placeholder); } } + element.setRenderer(this); return null; }