| commit | 4c9f2fb3751fe149546e47b502480a3f518c2569 | [log] [tgz] |
|---|---|---|
| author | Andreas Sewe <andreas.sewe@codetrails.com> | Fri Aug 11 10:31:47 2017 +0200 |
| committer | Andreas Sewe <andreas.sewe@codetrails.com> | Fri Aug 11 10:31:47 2017 +0200 |
| tree | 507aab766930f4669a63b88d2fb46d49ed977071 | |
| parent | a4862d5edeaaca5f3513e7cc1549f04b960dfb6f [diff] |
Use ArrayContentProvider.getInstance() where possible As ArrayContentProvider is stateless, re-using the global instance avoids a few allocations. Change-Id: I66ef570ee5659e61ab1881365e9058dcd5cdd509 Signed-off-by: Andreas Sewe <andreas.sewe@codetrails.com>
diff --git a/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/PreferencePage.java b/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/PreferencePage.java index e479e34..077a647 100644 --- a/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/PreferencePage.java +++ b/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/PreferencePage.java
@@ -106,7 +106,7 @@ ComboViewer sendMode = new ComboViewer(container); sendMode.getControl().setToolTipText(Messages.TOOLTIP_SEND_MODE); - sendMode.setContentProvider(new ArrayContentProvider()); + sendMode.setContentProvider(ArrayContentProvider.getInstance()); sendMode.setInput(SendMode.VALUES); sendMode.setLabelProvider(new SendModeLabelProvider());
diff --git a/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/ReviewDialog.java b/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/ReviewDialog.java index 149c69f..7e9f88b 100644 --- a/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/ReviewDialog.java +++ b/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/ReviewDialog.java
@@ -321,7 +321,7 @@ } { severity = new ComboViewer(detailsArea); - severity.setContentProvider(new ArrayContentProvider()); + severity.setContentProvider(ArrayContentProvider.getInstance()); severity.setInput(Severity.VALUES); severity.setLabelProvider(new LabelProvider() {
diff --git a/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/SystemSettingsPage.java b/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/SystemSettingsPage.java index 5329056..05b963c 100644 --- a/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/SystemSettingsPage.java +++ b/bundles/org.eclipse.epp.logging.aeri.ide/src/org/eclipse/epp/internal/logging/aeri/ide/dialogs/SystemSettingsPage.java
@@ -154,7 +154,7 @@ ComboViewer sendMode = new ComboViewer(container); sendMode.getControl().setToolTipText(Messages.TOOLTIP_SEND_MODE); - sendMode.setContentProvider(new ArrayContentProvider()); + sendMode.setContentProvider(ArrayContentProvider.getInstance()); sendMode.setInput(SendMode.VALUES); sendMode.setLabelProvider(new SendModeLabelProvider());