Apply "Primitive parsing" JDT cleanup to platform.debug
A boxed primitive is created from a String, just to extract the unboxed
primitive value.It is more efficient to just call the static parseXXX
method.
Before:
int number = Integer.valueOf("42", 8);
new Double("42.42").doubleValue();
After:
int number = Integer.parseInt("42", 8);
Double.parseDouble("42.42");
Change-Id: Iabf76750aca8e9c2d348b94f79cfb01d7b59998b
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/importexport/breakpoints/WizardExportBreakpointsPage.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/importexport/breakpoints/WizardExportBreakpointsPage.java
index 2b9d737..eb91c48 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/importexport/breakpoints/WizardExportBreakpointsPage.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/importexport/breakpoints/WizardExportBreakpointsPage.java
@@ -269,7 +269,7 @@
private void restoreWidgetState() {
IDialogSettings settings = getDialogSettings();
if(settings != null) {
- fOverwriteExistingFilesCheckbox.setSelection(Boolean.valueOf(settings.get(OVERWRITE_ALL_STATE)).booleanValue());
+ fOverwriteExistingFilesCheckbox.setSelection(Boolean.parseBoolean(settings.get(OVERWRITE_ALL_STATE)));
String filename = settings.get(DESTINATION_FILE_NAME);
if (filename != null) {
fDestinationNameField.setText(filename);
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/importexport/breakpoints/WizardImportBreakpointsPage.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/importexport/breakpoints/WizardImportBreakpointsPage.java
index 40c3824..873e6a7 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/importexport/breakpoints/WizardImportBreakpointsPage.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/importexport/breakpoints/WizardImportBreakpointsPage.java
@@ -183,8 +183,8 @@
private void restoreWidgetState() {
IDialogSettings settings = getDialogSettings();
if(settings != null) {
- fAutoRemoveDuplicates.setSelection(Boolean.valueOf(settings.get(REMOVE_DUPS)).booleanValue());
- fAutoCreateWorkingSets.setSelection(Boolean.valueOf(settings.get(CREATE_WORKING_SETS)).booleanValue());
+ fAutoRemoveDuplicates.setSelection(Boolean.parseBoolean(settings.get(REMOVE_DUPS)));
+ fAutoCreateWorkingSets.setSelection(Boolean.parseBoolean(settings.get(CREATE_WORKING_SETS)));
String fileName = settings.get(SOURCE_FILE_NAME);
if (fileName != null) {
fFileNameField.setText(fileName);
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java
index af6d76e..25d7ff7 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationsDialog.java
@@ -1655,7 +1655,7 @@
@Override
public IStatus runInUIThread(IProgressMonitor monitor) {
TreeViewer viewer = fLaunchConfigurationView.getTreeViewer();
- boolean newvalue = Boolean.valueOf(event.getNewValue().toString()).booleanValue();
+ boolean newvalue = Boolean.parseBoolean(event.getNewValue().toString());
if(event.getProperty().equals(IInternalDebugUIConstants.PREF_FILTER_LAUNCH_CLOSED)) {
updateFilter(newvalue, fClosedProjectFilter);
}
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/LaunchConfigurationsPreferencePage.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/LaunchConfigurationsPreferencePage.java
index d51ed86..f01e092 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/LaunchConfigurationsPreferencePage.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/LaunchConfigurationsPreferencePage.java
@@ -232,7 +232,7 @@
newvalue = ((Boolean)event.getNewValue()).booleanValue();
}
else {
- newvalue = Boolean.valueOf(event.getNewValue().toString()).booleanValue();
+ newvalue = Boolean.parseBoolean(event.getNewValue().toString());
}
if(newvalue) {
fTable.setEnabled(true);
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/AsyncTableRenderingCellModifier.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/AsyncTableRenderingCellModifier.java
index 801b2c7..c1d6d90 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/AsyncTableRenderingCellModifier.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/AsyncTableRenderingCellModifier.java
@@ -83,7 +83,7 @@
// numberofAddressableUnit * addressableSize
int addressableSize = getAddressableSize();
- int offset = Integer.valueOf(property, 16).intValue() * addressableSize;
+ int offset = Integer.parseInt(property, 16) * addressableSize;
MemoryByte[] bytes = line.getBytes(offset, fRendering.getBytesPerColumn());
@@ -132,10 +132,10 @@
return line.getAddress();
}
- int offsetToLineBuffer = Integer.valueOf(property, 16).intValue() * getAddressableSize();
+ int offsetToLineBuffer = Integer.parseInt(property, 16) * getAddressableSize();
MemoryByte[] memory = line.getBytes(offsetToLineBuffer, fRendering.getBytesPerColumn());
- int offsetFromLineAddress = Integer.valueOf(property, 16).intValue();
+ int offsetFromLineAddress = Integer.parseInt(property, 16);
BigInteger address = line.getAddress().add(BigInteger.valueOf(offsetFromLineAddress));
if (fCustomModifier != null)
@@ -181,7 +181,7 @@
final IMemoryBlock memoryBlk = fRendering.getMemoryBlock();
// number of addressable units from the line's start address
- int offsetFromLineAddress = Integer.valueOf(property, 16).intValue();
+ int offsetFromLineAddress = Integer.parseInt(property, 16);
// this offset is number of addressable unit from memory block's base address
final BigInteger offsetFromMBBase = getOffset(memoryBlk, line.getAddress(), offsetFromLineAddress);
@@ -189,7 +189,7 @@
// property is number of addressable unit from line address
// to calculate proper offset in the memoryViewLine's array
// offset = numberOfAddressableUnit * addressableSize
- int offsetToLineBuffer = Integer.valueOf(property, 16).intValue() * getAddressableSize();
+ int offsetToLineBuffer = Integer.parseInt(property, 16) * getAddressableSize();
MemoryByte[] oldArray = line.getBytes(offsetToLineBuffer, fRendering.getBytesPerColumn());
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/TableRenderingCellModifier.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/TableRenderingCellModifier.java
index c88de3f..33d0bef 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/TableRenderingCellModifier.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/memory/renderings/TableRenderingCellModifier.java
@@ -72,7 +72,7 @@
// numberofAddressableUnit * addressableSize
int addressableSize = getAddressableSize();
- int offset = Integer.valueOf(property, 16).intValue() * addressableSize;
+ int offset = Integer.parseInt(property, 16) * addressableSize;
int end = offset + fRendering.getBytesPerColumn();
for (int i = offset; i < end; i++) {
@@ -114,7 +114,7 @@
return line.getAddress();
}
- int offset = Integer.valueOf(property, 16).intValue() * getAddressableSize();
+ int offset = Integer.parseInt(property, 16) * getAddressableSize();
int end = offset + fRendering.getBytesPerColumn();
// Ask for label provider
@@ -122,7 +122,7 @@
if (line.isAvailable(offset, end)) {
// ask the renderer for a string representation of the bytes
- offset = Integer.valueOf(property, 16).intValue();
+ offset = Integer.parseInt(property, 16);
BigInteger address = new BigInteger(((TableRenderingLine) element).getAddress(), 16);
address = address.add(BigInteger.valueOf(offset));
@@ -154,7 +154,7 @@
// calculate offset to update
IMemoryBlock memoryBlk = fRendering.getMemoryBlock();
- int lineOffset = Integer.valueOf(property, 16).intValue();
+ int lineOffset = Integer.parseInt(property, 16);
// this offset is number of addressable unit from the line address
BigInteger offset = getOffset(memoryBlk, line.getAddress(), lineOffset);
@@ -168,7 +168,7 @@
// property is number of addressable unit from line address
// to calculate proper offset in the memoryViewLine's array
// offset = numberOfAddressableUnit * addressableSize
- int offsetToLine = Integer.valueOf(property, 16).intValue() * getAddressableSize();
+ int offsetToLine = Integer.parseInt(property, 16) * getAddressableSize();
int end = offsetToLine + fRendering.getBytesPerColumn();
MemoryByte[] oldArray = line.getBytes(offsetToLine, end);
