Bug 519783 - HTMLPrinter should migrate to StringBuilder
Change-Id: I2ad223b52c4f1d280a20160ea6f7414b4d5e6fe8
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
diff --git a/ant/org.eclipse.ant.ui/Ant Editor/org/eclipse/ant/internal/ui/editor/text/XMLAnnotationHover.java b/ant/org.eclipse.ant.ui/Ant Editor/org/eclipse/ant/internal/ui/editor/text/XMLAnnotationHover.java
index 157dd0b..7f3003b 100644
--- a/ant/org.eclipse.ant.ui/Ant Editor/org/eclipse/ant/internal/ui/editor/text/XMLAnnotationHover.java
+++ b/ant/org.eclipse.ant.ui/Ant Editor/org/eclipse/ant/internal/ui/editor/text/XMLAnnotationHover.java
@@ -17,9 +17,7 @@
import java.util.Map;
import org.eclipse.ant.internal.ui.editor.AntEditorMessages;
-
import org.eclipse.jface.internal.text.html.HTMLPrinter;
-
import org.eclipse.jface.text.BadLocationException;
import org.eclipse.jface.text.IDocument;
import org.eclipse.jface.text.Position;
@@ -164,7 +162,7 @@
* Formats a message as HTML text.
*/
private String formatSingleMessage(String message) {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
HTMLPrinter.addPageProlog(buffer);
HTMLPrinter.addParagraph(buffer, HTMLPrinter.convertToHTMLContent(message));
HTMLPrinter.addPageEpilog(buffer);
@@ -175,7 +173,7 @@
* Formats several message as HTML text.
*/
private String formatMultipleMessages(List<String> messages) {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
HTMLPrinter.addPageProlog(buffer);
HTMLPrinter.addParagraph(buffer, HTMLPrinter.convertToHTMLContent(AntEditorMessages.getString("AntAnnotationHover.multipleMarkersAtThisLine"))); //$NON-NLS-1$
diff --git a/ant/org.eclipse.ant.ui/Ant Editor/org/eclipse/ant/internal/ui/editor/text/XMLTextHover.java b/ant/org.eclipse.ant.ui/Ant Editor/org/eclipse/ant/internal/ui/editor/text/XMLTextHover.java
index 1d9eb12..a6136cd 100644
--- a/ant/org.eclipse.ant.ui/Ant Editor/org/eclipse/ant/internal/ui/editor/text/XMLTextHover.java
+++ b/ant/org.eclipse.ant.ui/Ant Editor/org/eclipse/ant/internal/ui/editor/text/XMLTextHover.java
@@ -62,7 +62,7 @@
* Formats a message as HTML text. Expects the message to already be properly escaped
*/
private String formatMessage(String message) {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
HTMLPrinter.addPageProlog(buffer);
HTMLPrinter.addParagraph(buffer, message);
HTMLPrinter.addPageEpilog(buffer);
@@ -73,7 +73,7 @@
* Formats a message as HTML text.
*/
private String formatPathMessage(String[] list) {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
HTMLPrinter.addPageProlog(buffer);
HTMLPrinter.addSmallHeader(buffer, AntEditorTextMessages.XMLTextHover_4);
HTMLPrinter.startBulletList(buffer);
@@ -85,11 +85,6 @@
return buffer.toString();
}
- /*
- * (non-Javadoc)
- *
- * @see org.eclipse.jface.text.ITextHover#getHoverInfo(org.eclipse.jface.text.ITextViewer, org.eclipse.jface.text.IRegion)
- */
@Override
public String getHoverInfo(ITextViewer textViewer, IRegion hoverRegion) {
@@ -198,7 +193,7 @@
}
private String formatSetMessage(String[] includes, String[] excludes) {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
HTMLPrinter.addPageProlog(buffer);
if (includes != null && includes.length > 0) {
HTMLPrinter.addSmallHeader(buffer, AntEditorTextMessages.XMLTextHover_5);
@@ -218,11 +213,6 @@
return buffer.toString();
}
- /*
- * (non-Javadoc)
- *
- * @see org.eclipse.jface.text.ITextHover#getHoverRegion(org.eclipse.jface.text.ITextViewer, int)
- */
@Override
public IRegion getHoverRegion(ITextViewer textViewer, int offset) {
if (textViewer != null) {
