| commit | b1e2b2212444cf28ca49b9a2c08a2abc70dbf48e | [log] [tgz] |
|---|---|---|
| author | jbouthillie <lmcbout@gmail.com> | Wed Mar 28 11:51:24 2012 -0400 |
| committer | jbouthillie <lmcbout@gmail.com> | Wed Mar 28 11:51:24 2012 -0400 |
| tree | 183fc5440a8d96710b8fa1c0c91ad81873e4ae59 | |
| parent | 47b97576e5b093b3045d22fb879d42ec8d33f5c6 [diff] |
NEW - bug 375551: Add a check to verify null pointer for the anomaly title https://bugs.eclipse.org/bugs/show_bug.cgi?id=375551 Adjust also the ui to verify the null pointer
diff --git a/org.eclipse.mylyn.reviews.frame.core/src/org/eclipse/mylyn/reviews/frame/core/model/impl/CommentImpl.java b/org.eclipse.mylyn.reviews.frame.core/src/org/eclipse/mylyn/reviews/frame/core/model/impl/CommentImpl.java index e4747bf..f795aff 100644 --- a/org.eclipse.mylyn.reviews.frame.core/src/org/eclipse/mylyn/reviews/frame/core/model/impl/CommentImpl.java +++ b/org.eclipse.mylyn.reviews.frame.core/src/org/eclipse/mylyn/reviews/frame/core/model/impl/CommentImpl.java
@@ -191,7 +191,7 @@ * @generated */ public String getDescription() { - return description; + return description!= null ? description : ""; } /**
diff --git a/org.eclipse.mylyn.reviews.frame.core/src/org/eclipse/mylyn/reviews/frame/core/model/impl/TopicImpl.java b/org.eclipse.mylyn.reviews.frame.core/src/org/eclipse/mylyn/reviews/frame/core/model/impl/TopicImpl.java index 29ae3ec..4f863e0 100644 --- a/org.eclipse.mylyn.reviews.frame.core/src/org/eclipse/mylyn/reviews/frame/core/model/impl/TopicImpl.java +++ b/org.eclipse.mylyn.reviews.frame.core/src/org/eclipse/mylyn/reviews/frame/core/model/impl/TopicImpl.java
@@ -262,7 +262,7 @@ * @generated */ public String getTitle() { - return title; + return title!= null ? title : ""; } /**
diff --git a/org.eclipse.mylyn.reviews.r4e.ui/src/org/eclipse/mylyn/reviews/r4e/ui/internal/model/R4EUIAnomalyBasic.java b/org.eclipse.mylyn.reviews.r4e.ui/src/org/eclipse/mylyn/reviews/r4e/ui/internal/model/R4EUIAnomalyBasic.java index 4ff6a9c..007514e 100644 --- a/org.eclipse.mylyn.reviews.r4e.ui/src/org/eclipse/mylyn/reviews/r4e/ui/internal/model/R4EUIAnomalyBasic.java +++ b/org.eclipse.mylyn.reviews.r4e.ui/src/org/eclipse/mylyn/reviews/r4e/ui/internal/model/R4EUIAnomalyBasic.java
@@ -271,10 +271,15 @@ * @return String */ protected static String adjustTitleLength(R4EAnomaly aAnomaly) { - if (aAnomaly.getTitle().length() > ANOMALY_LABEL_TITLE_LENGTH) { - return aAnomaly.getTitle().substring(0, ANOMALY_LABEL_TITLE_LENGTH) + R4EUIConstants.ELLIPSIS_STR; + String anomalyTitle = aAnomaly.getTitle(); + + if (anomalyTitle == null) { + return ""; //return an empty string for the null title + } + if (anomalyTitle.length() > ANOMALY_LABEL_TITLE_LENGTH) { + return anomalyTitle.substring(0, ANOMALY_LABEL_TITLE_LENGTH) + R4EUIConstants.ELLIPSIS_STR; } else { - return aAnomaly.getTitle(); + return anomalyTitle; } }