commit 3f475e34d6036a1b61995c22c740ebe5ee3e6dbb
author Philipp Maier <pmaier@sysmocom.de> Tue Jan 05 15:56:40 2021 +0100
committer Philipp Maier <pmaier@sysmocom.de> Wed Feb 03 19:52:33 2021 +0100
tree 3bc2e00cfca5c99894efa97af33fe6f68d575b36
parent c447f28569289fa411106ea90eb1bcf2099e70a6

BSSGP_Types: Fix coding of Reporting Cell Identifier

3GPP TS 48.018 V10.6.0 (2020-09), section 11.3.63.1.1-3 describes the reporting
Cell Identifier IE coding as follows: "Reporting Cell Identifier: This field
is encoded as the Cell Identifier defined in sub-clause 11.3.9", but when
looking further at 11.3.63.2.1-3 the Cell Identifier IE is described as
"Reporting Cell Identifier: This field is encoded as the value part of the
Cell Identifier IE defined in sub-clause 11.3.9, not including IEI and Length
Indicator." The latter description makes more sense, since technically the
IE and length of the Cell Identifier from 11.3.9 would be redundant.

Change-Id: I7365993366a92db3aa7e3982c6b45d97da225acd
Signed-off-by: Philipp Maier <pmaier@sysmocom.de>

src/BSSGP_Types.ttcn

diff --git a/src/BSSGP_Types.ttcn b/src/BSSGP_Types.ttcn
index c2749dd..3b45abc 100644
--- a/src/BSSGP_Types.ttcn
+++ b/src/BSSGP_Types.ttcn
@@ -2002,6 +2002,15 @@
 RAN_Information_Request_Application_Container_MBMS_data_channel mBMS_data_channel
 }
 
+/* NOTE: 3GPP TS 48.018 V10.6.0 (2020-09), section 11.3.63.1.1-3 describes the
+ * reporting Cell Identifier IE coding as follows: "Reporting Cell Identifier:
+ * This field is encoded as the Cell Identifier defined in sub-clause 11.3.9",
+ * but when looking further at 11.3.63.2.1-3 the Cell Identifier IE is described
+ * as "Reporting Cell Identifier: This field is encoded as the value part of
+ * the Cell Identifier IE defined in sub-clause 11.3.9, not including IEI and
+ * Length Indicator." The latter description makes more sense, since
+ * technically the IE and length of the Cell Identifier from 11.3.9 would be
+ * redundant. */
 
 //Table 11.3.63.1.1
 type record RAN_Information_Request_Application_Container_NACC
@@ -2009,7 +2018,7 @@
  OCT1                   iEI,
  BIT1                   ext,
  LIN2_2a                lengthIndicator,
- Cell_Identifier        reporting_Cell_Identifier
+ Cell_Identifier_V      reporting_Cell_Identifier
 } with { 
   variant "PRESENCE(iEI = '4D'O)";
   variant (lengthIndicator) "LENGTHTO (reporting_Cell_Identifier)";     
@@ -2024,7 +2033,7 @@
  OCT1                   iEI,
  BIT1                   ext,
  LIN2_2a                lengthIndicator,
- Cell_Identifier        reporting_Cell_Identifier
+ Cell_Identifier_V      reporting_Cell_Identifier
 } with { 
   variant "PRESENCE(iEI = '4D'O)";
    variant (lengthIndicator) "LENGTHTO (reporting_Cell_Identifier)";     
@@ -2039,7 +2048,7 @@
  OCT1                   iEI,
  BIT1                   ext,
  LIN2_2a                lengthIndicator,
- Cell_Identifier        reporting_Cell_Identifier
+ Cell_Identifier_V      reporting_Cell_Identifier
 } with { 
   variant "PRESENCE(iEI = '4D'O)";
   variant (lengthIndicator) "LENGTHTO (reporting_Cell_Identifier)";     
@@ -2085,7 +2094,7 @@
  OCT1                   iEI,
  BIT1                   ext,
  LIN2_2a                lengthIndicator,
- Cell_Identifier        reporting_Cell_Identifier,
+ Cell_Identifier_V      reporting_Cell_Identifier,
  BIT1                   typeBit,
  BIT7                   number_of_SI_PSI,
  octetstring            sI_PSI
@@ -2104,7 +2113,7 @@
  OCT1                   iEI,
  BIT1                   ext,
  LIN2_2a                lengthIndicator,
- Cell_Identifier        reporting_Cell_Identifier,
+ Cell_Identifier_V      reporting_Cell_Identifier,
  SI3                    sI3
 } with { 
   variant "PRESENCE(iEI = '4E'O)";
@@ -2185,7 +2194,7 @@
  OCT1                      iEI,
  BIT1                      ext,
  LIN2_2a                   lengthIndicator,
- Cell_Identifier           reporting_Cell_Identifier,
+ Cell_Identifier_V         reporting_Cell_Identifier,
  octetstring               mBMS_data_channel_report  //bit encoded
 } with { 
   variant "PRESENCE(iEI = '4E'O)";