commit 0be41216e712bf1f0c7975012ec7bf33d8b18b31
author Vladimir Piskarev <pisv@1c.ru> Mon May 29 19:27:49 2017 +0300
committer Vladimir Piskarev <pisv@1c.ru> Mon May 29 19:27:49 2017 +0300
tree 6a67c3e7f777771318881ad209208fa24c945133
parent 1225c13a502ab7aa993a2ff44b243912af962b32

Fixed potential NPE in ElementDelta.Builder

org.eclipse.handly/src/org/eclipse/handly/model/impl/ElementDelta.java

diff --git a/org.eclipse.handly/src/org/eclipse/handly/model/impl/ElementDelta.java b/org.eclipse.handly/src/org/eclipse/handly/model/impl/ElementDelta.java
index 8b09087..d6ff418 100644
--- a/org.eclipse.handly/src/org/eclipse/handly/model/impl/ElementDelta.java
+++ b/org.eclipse.handly/src/org/eclipse/handly/model/impl/ElementDelta.java
@@ -1149,19 +1149,22 @@
                 delta = findDelta(element);
             }
 
-            switch (delta.hKind())
+            if (delta != null)
             {
-            case ADDED:
-            case REMOVED:
-                break; // do nothing
-            case CHANGED:
-                delta.hSetFlags(delta.hFlags() | F_MARKERS);
-                delta.hSetMarkerDeltas(markerDeltas);
-                break;
-            default: // empty delta
-                delta.hSetKind(CHANGED);
-                delta.hSetFlags(delta.hFlags() | F_MARKERS);
-                delta.hSetMarkerDeltas(markerDeltas);
+                switch (delta.hKind())
+                {
+                case ADDED:
+                case REMOVED:
+                    break; // do nothing
+                case CHANGED:
+                    delta.hSetFlags(delta.hFlags() | F_MARKERS);
+                    delta.hSetMarkerDeltas(markerDeltas);
+                    break;
+                default: // empty delta
+                    delta.hSetKind(CHANGED);
+                    delta.hSetFlags(delta.hFlags() | F_MARKERS);
+                    delta.hSetMarkerDeltas(markerDeltas);
+                }
             }
             return this;
         }
@@ -1191,19 +1194,22 @@
                 delta = findDelta(element);
             }
 
-            switch (delta.hKind())
+            if (delta != null)
             {
-            case ADDED:
-            case REMOVED:
-                break; // do nothing
-            case CHANGED:
-                delta.hSetFlags(delta.hFlags() | F_CONTENT);
-                delta.hAddResourceDelta(resourceDelta);
-                break;
-            default: // empty delta
-                delta.hSetKind(CHANGED);
-                delta.hSetFlags(delta.hFlags() | F_CONTENT);
-                delta.hAddResourceDelta(resourceDelta);
+                switch (delta.hKind())
+                {
+                case ADDED:
+                case REMOVED:
+                    break; // do nothing
+                case CHANGED:
+                    delta.hSetFlags(delta.hFlags() | F_CONTENT);
+                    delta.hAddResourceDelta(resourceDelta);
+                    break;
+                default: // empty delta
+                    delta.hSetKind(CHANGED);
+                    delta.hSetFlags(delta.hFlags() | F_CONTENT);
+                    delta.hAddResourceDelta(resourceDelta);
+                }
             }
             return this;
         }