commit | 9f24457091da000f694220f098c177d686ab0952 | [log] [tgz] |
---|---|---|
author | Leo Ufimtsev <lufimtse@redhat.com> | Wed May 10 14:36:19 2017 -0400 |
committer | Leo Ufimtsev <lufimtse@redhat.com> | Thu May 11 09:54:55 2017 -0400 |
tree | 69f2ba081eb4613a169750f91014f67f3ace2eff | |
parent | 37dd64af3ce572c7755b1bb2f8887ff6ebcc87c0 [diff] |
Bug 516420: Problem hover status color should be the same as for normal content Adding missing set*Color() calls to fix reported bug. Cause: AbstractAnnotationHover extends AbstractInformationControl and does some setColoring for it's private child composite without updating the color of the parent structure. Test: - Change information hover colors in preference - Hover over snippet described in bug description Before: Strip at the bottom was of different color. After: Strip at the bottom is the same color as inner content. (see attached screenshot in bug). Reviewer note: - I investigated private setColorAndFont(..). It is only used for coloring of child elements, and only in deferredCreateContent(). As such, there is no situation where setColorAndFont(..) would be called without set*Color() being called first. This ensures consistent colors for this class. Note, after doing a root-cause analysis, I found the same sort-of issue in a few other classes that extend AbstractInformationControl, namely: - BrowserInformationControl - ExpressionInformationControl - LinkListInformationControl I will address those in separate bug because they 1) need the new INFORMATION_ api (instead of further using HOVER_) 2) some are in separate repositories. (jdt/platform) Change-Id: I837eceaf00b8ab8162f8490a1b48425bfc38210d Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=516420 Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
Thanks for your interest in this project.
The JDT UI implements the user interface for the Java IDE. This includes views like Package Explorer and JUnit, the Java and properties files editors, Java search, and refactorings. Website: http://www.eclipse.org/jdt/ui/
Contributions to JDT UI are most welcome. There are many ways to contribute, from entering high quality bug reports, to contributing code or documentation changes. For a complete guide, see the [How to Contribute] 1 page on the team wiki.
Information regarding source code management, builds, coding standards, and more.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Public forum for Eclipse JDT users.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!
Contact the project developers via the project's “dev” list.