| commit | 3d71c53dac5e7202fc20589e81425352b4fe8c12 | [log] [tgz] |
|---|---|---|
| author | Carsten Hammer <carsten.hammer@t-online.de> | Sat Sep 19 11:38:43 2020 +0200 |
| committer | Jeff Johnston <jjohnstn@redhat.com> | Wed Sep 30 16:09:11 2020 -0400 |
| tree | 1eb8eb2b3c0a6cea173764951aa22ebea3ca57b3 | |
| parent | 10dd44765053fc84d315a003ff8f59ff000f69ee [diff] |
Bug 564185 - return true in case F_CONTENT and F_FINE_GRAINED is set
Bug: Incompatible bit masks in (e | 0x4000 == 0x1) yields constant
result in
org.eclipse.jdt.internal.ui.javaeditor.JavaEditorBreadcrumb$ElementChangeListener.isStructuralChange(IJavaElementDelta)
This method compares an expression of the form (e | C) to D. which will
always compare unequal due to the specific values of constants C and D.
This may indicate a logic error or typo.
Typically, this bug occurs because the code wants to perform a
membership test in a bit set, but uses the bitwise OR operator ("|")
instead of bitwise AND ("&").
Also such bug may appear in expressions like (e & A | B) == C which is
parsed like ((e & A) | B) == C while (e & (A | B)) == C was intended.
Rank: Scary (5), confidence: High
Pattern: BIT_IOR
Type: BIT, Category: CORRECTNESS (Correctness)
Change-Id: Ic7c4a21a6e4330fcbb54c7350d95ee1dfff8b65d
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>Thanks for your interest in this project.
The JDT UI implements the user interface for the Java IDE. This includes views like Package Explorer and JUnit, the Java and properties files editors, Java search, and refactorings. Website: http://www.eclipse.org/jdt/ui/
Contributions to JDT UI are most welcome. There are many ways to contribute, from entering high quality bug reports, to contributing code or documentation changes. For a complete guide, see the [How to Contribute] 1 page on the team wiki.
Information regarding source code management, builds, coding standards, and more.
Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
Public forum for Eclipse JDT users.
This project uses Bugzilla to track ongoing development and issues.
Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!
Contact the project developers via the project's “dev” list.